Re: [PATCH] kernel-yocto.bbclass: Fixup shell condition test syntax error

[Bruce Ashfield <bruce.ashfield@windriver.com>]

On 14-09-26 03:04 PM, Darren Hart wrote:
> A warning is issued when run about an unexpected operator due to a
> syntax error with an extra if empedded in the shell conditional. Remove
> the extra if.

ouch. How on earth did that survive ?

Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>

>
> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
> Cc: Bruce Ashfield <bruce.ashfield@windriver.com>
> ---
>   meta/classes/kernel-yocto.bbclass | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/kernel-yocto.bbclass b/meta/classes/kernel-yocto.bbclass
> index 929d64a..7718f9a 100644
> --- a/meta/classes/kernel-yocto.bbclass
> +++ b/meta/classes/kernel-yocto.bbclass
> @@ -296,7 +296,7 @@ do_validate_branches() {
>   		force_srcrev="${SRCREV}"
>   	else
>   		git cat-file -t ${machine_srcrev} > /dev/null
> -		if [ if $? -ne 0 ]; then
> +		if [ $? -ne 0 ]; then
>   			bberror "${machine_srcrev} is not a valid commit ID."
>   			bbfatal "The kernel source tree may be out of sync"
>   		fi
>