All of lore.kernel.org
 help / color / mirror / Atom feed
From: BillStuff <billstuff2001@sbcglobal.net>
To: NeilBrown <neilb@suse.de>
Cc: linux RAID <linux-raid@vger.kernel.org>
Subject: Re: [GIT PULL REQUEST] late md/raid1 bug fixes for 3.17
Date: Fri, 26 Sep 2014 14:08:08 -0500	[thread overview]
Message-ID: <5425B998.7080304@sbcglobal.net> (raw)
In-Reply-To: <20140924121805.1b8c3bd9@notabene.brown>

On 09/23/2014 09:18 PM, NeilBrown wrote:
[snip]
>        md/raid1: intialise start_next_window for READ case to avoid hang
>

Neil, I've been testing these patches for the past week or two to see if 
they help a raid1 "check" hang I had.

They seem to help, but I noticed the above patch is different from what 
you originally sent on the list.

The original patch has an extra chunk:

@@ -1444,6 +1445,7 @@ read_again:
		r1_bio->state = 0;
		r1_bio->mddev = mddev;
		r1_bio->sector = bio->bi_iter.bi_sector + sectors_handled;
+		start_next_window = wait_barrier(conf, bio);
		goto retry_write;
	}

Is the correct patch with or without this chunk?

Thanks,
Bill

  reply	other threads:[~2014-09-26 19:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-24  2:18 [GIT PULL REQUEST] late md/raid1 bug fixes for 3.17 NeilBrown
2014-09-26 19:08 ` BillStuff [this message]
2014-09-27  0:09   ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5425B998.7080304@sbcglobal.net \
    --to=billstuff2001@sbcglobal.net \
    --cc=linux-raid@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.