Re: [PATCH 6/6] x86/svm: Misc cleanup

[Boris Ostrovsky <boris.ostrovsky@oracle.com>]

On 09/23/2014 11:03 AM, Andrew Cooper wrote:
> cpu_has_monitor_trap_flag is a VMX control, and has nothing to do with SVM.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Boris Ostrovsky <boris.ostrovsky@oracle.com>
> CC: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> CC: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>

Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>



> ---
>   xen/arch/x86/hvm/svm/svm.c |    2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/xen/arch/x86/hvm/svm/svm.c b/xen/arch/x86/hvm/svm/svm.c
> index 4823c80..73f3108 100644
> --- a/xen/arch/x86/hvm/svm/svm.c
> +++ b/xen/arch/x86/hvm/svm/svm.c
> @@ -1188,8 +1188,6 @@ static void svm_inject_trap(struct hvm_trap *trap)
>               __restore_debug_registers(vmcb, curr);
>               vmcb_set_dr6(vmcb, vmcb_get_dr6(vmcb) | 0x4000);
>           }
> -        if ( cpu_has_monitor_trap_flag )
> -            break;
>           /* fall through */
>       case TRAP_int3:
>           if ( curr->domain->debugger_attached )