From: Lars-Peter Clausen <lars@metafoo.de>
To: Anatol Pomozov <anatol.pomozov@gmail.com>
Cc: alsa-devel@alsa-project.org, broonie@kernel.org
Subject: Re: [PATCH] ASoC: ssm4567: Add driver for Analog Devices SSM4567 amplifier
Date: Fri, 26 Sep 2014 22:42:20 +0200 [thread overview]
Message-ID: <5425CFAC.6080607@metafoo.de> (raw)
In-Reply-To: <CAOMFOmUOzO1M_1TKPommxuj9G8d42_DxQMwF7KVcK=8G022EBw@mail.gmail.com>
On 09/26/2014 10:38 PM, Anatol Pomozov wrote:
> I've fixed the items you mentioned.
>
> One difference I spotted between your and mine patches is that you
> don't call regcache_cache_only(regmap) before powering down the
> device. Is it because I2C alive in power down mode? I guess I need to
> remove regcache_cache_only() then.
>
Yes, the interface should be alive, unless of course you disable the
regulator. But having the regcache_cache_only() should not hurt, except that
we need to resync the registers on power on, which can cause small
additional delays.
- Lars
next prev parent reply other threads:[~2014-09-26 20:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 16:08 [PATCH] ASoC: ssm4567: Add driver for Analog Devices SSM4567 amplifier Anatol Pomozov
2014-09-26 17:13 ` Lars-Peter Clausen
2014-09-26 20:38 ` Anatol Pomozov
2014-09-26 20:42 ` Lars-Peter Clausen [this message]
2014-09-26 20:31 ` Anatol Pomozov
2014-09-26 20:46 ` Lars-Peter Clausen
2014-09-26 20:49 ` Anatol Pomozov
2014-09-27 10:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5425CFAC.6080607@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=anatol.pomozov@gmail.com \
--cc=broonie@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.