From mboxrd@z Thu Jan 1 00:00:00 1970 From: Aaron Plattner Subject: Re: Stupid NVIDIA 3D vgaarb.c patch Date: Fri, 26 Sep 2014 14:08:29 -0700 Message-ID: <5425D5CD.4000002@nvidia.com> References: <1411504140.4184.26.camel@pasglop> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from hqemgate15.nvidia.com (hqemgate15.nvidia.com [216.228.121.64]) by gabe.freedesktop.org (Postfix) with ESMTP id 6BCDC6E042 for ; Fri, 26 Sep 2014 14:08:31 -0700 (PDT) In-Reply-To: <1411504140.4184.26.camel@pasglop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Benjamin Herrenschmidt , Linus Torvalds Cc: =?UTF-8?B?QyBCZXJnc3Ryw7Zt?= , Alex Williamson , DRI , Linux Kernel Mailing List List-Id: dri-devel@lists.freedesktop.org T24gMDkvMjMvMjAxNCAwMToyOSBQTSwgQmVuamFtaW4gSGVycmVuc2NobWlkdCB3cm90ZToKPiBP biBNb24sIDIwMTQtMDktMjIgYXQgMTM6NDMgLTA3MDAsIExpbnVzIFRvcnZhbGRzIHdyb3RlOgo+ PiBBZGRpbmcgcHJvcGVyIHBlb3BsZSBhbmQgbWFpbGluZyBsaXN0cy4uCj4+Cj4+IFRoZSBQQ0lf Q0xBU1NfRElTUExBWV9WR0EgdGVzdCBnb2VzIGJhY2sgdG8gdGhlIHZlcnkgYmVnaW5uaW5nIGJ5 Cj4+IEJlbkgsIGFuZCBJIGhhdmUgbm8gaWRlYSBpZiBhZGRpbmcgUENJX0NMQVNTX0RJU1BMQVlf M0QgaXMKPj4gYXBwcm9wcmlhdGUsIGJ1dCBob3BlZnVsbHkgc29tZWJvZHkgZG9lcy4gVGhlIGZh Y3QgdGhhdCBpdCBtYWtlcwo+PiB0aGluZ3Mgd29yayBjZXJ0YWlubHkgYXJndWVzIGZhaXJseSBj b252aW5jaW5nbHkgZm9yIGl0LCBidXQgSSB3YW50Cj4+IHNvbWUgYmFja3VwIGhlcmUuCj4+Cj4+ IERhdmUsIEJlbkg/Cj4+Cj4+IENocmlzdG9waGVyKD8pLCBjYW4geW91IHBsZWFzZSBhbHNvIHNw ZWNpZnkgd2hpY2ggbGFwdG9wIGV0Yy4gQW5kIHRoZQo+PiBwYXRjaCBpdHNlbGYgc2VlbXMgdG8g aGF2ZSBjb21lIGZyb20gc29tZWJvZHkgZWxzZSwgdW5sZXNzIHlvdSdyZQo+PiBMZWtlbnN0ZXlu LiBTbyB3ZSdkIHdhbnQgdG8gZ2V0IHRoZSBwcm92ZW5hbmNlIG9mIHRoYXQgdG9vLgo+Cj4gSHJt LCB0aGF0IHN1Y2tzLiAiM0QiIGNvdWxkIG1lYW4gYW55dGhpbmcgcmVhbGx5LCB3ZSBtaWdodCBu ZWVkIGFuCj4gZXhwbGljaXQgdmVuZG9yIElEIGNoZWNrIGFzIHdlbGwgYW5kIG1heWJlIGV2ZW4g ZGV2aWNlIElEIC4uLgoKSWYgbXkgdW5kZXJzdGFuZGluZyBpcyBjb3JyZWN0LCB0aGUgYm9hcmQg ZGVzaWduZXJzIGV4cGxpY2l0bHkgbWFyayB0aGVtIAphcyAiM0QgY29udHJvbGxlciIgd2hlbiB0 aGV5IGRvbid0IGhhdmUgYW55IG91dHB1dHMgY29ubmVjdGVkLCAKc3BlY2lmaWNhbGx5IHNvIHRo ZSBTQklPUyB3b24ndCBjaG9vc2UgdGhlbSBhcyB0aGUgYm9vdCBWR0EgZGV2aWNlLiAKRGVwZW5k aW5nIG9uIHRoZSBkZXNpZ24sIHNvbWUgR1BVcyBvbiB0aGVzZSAzRCBjb250cm9sbGVyIGJvYXJk cyBkb24ndCAKaGF2ZSBhIGRpc3BsYXkgZW5naW5lIGF0IGFsbCwgd2hpbGUgb3RoZXJzIHN0aWxs IGhhdmUgaXQgaW4gdGhlIHNpbGljb24gCmJ1dCBsZWF2ZSBpdCBkaXNhYmxlZCBhdCBydW50aW1l LiAgSW4gZWl0aGVyIGNhc2UsIFZHQSBzaG91bGQgbm90IGJlIApyb3V0ZWQgdG8gdGhlbSBhbmQg SSBkb24ndCB0aGluayB0aGV5IHNob3VsZCBuZWVkIHRvIHBhcnRpY2lwYXRlIGluIFZHQSAKYXJi aXRyYXRpb24uCgotLSBBYXJvbgoKPiBCZW4uCj4KPj4gICAgICAgICAgICAgICAgICBMaW51cwo+ Pgo+PiBPbiBNb24sIFNlcCAyMiwgMjAxNCBhdCAxOjI4IFBNLCBDIEJlcmdzdHLDtm0gPGNiZXJn c3Ryb21AcGF0aHNjYWxlLmNvbT4gd3JvdGU6Cj4+PiBIaSBMaW51cywKPj4+Cj4+PiBJIGRvbid0 IGtub3cgd2hvIHRoZSBvcmlnaW5hbCBhdXRob3IgaXMgYW5kIEkgY2FuIGhhdmUgb25lIG9mIHRo ZSBkaXN0cm8KPj4+IGdyYXBoaWNzIGZyaWVuZHMgcmV2aWV3IGl0LCBidXQgSSBuZWVkIHRoaXMg cGF0Y2ggYmVsb3cgdG8gZ2V0IE5WSURJQQo+Pj4gZHJpdmVycyB0byB3b3JrICh3aXRob3V0IHVz aW5nIGFueSBJbnRlbCBncmFwaGljcykgb24gbXkgbGFwdG9wCj4+PiBodHRwOi8vcGFzdGViaW4u Y29tL3dwbUZpMzhrCj4+Pgo+Pj4gU29ycnkgLSBJIGtub3cgdGhpcyBpcyBub3QgdGhlIHByb3Bl ciB3YXkgdG8gc3VibWl0IGEgcGF0Y2gsIGJ1dCBpdCdzCj4+PiB0cml2aWFsIGFuZCBJJ20gbm90 IGEga2VybmVsIGRldi4KPj4+Cj4+PiBUaGFua3MKPj4+Cj4+PiAuL0MKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756274AbaIZVIc (ORCPT ); Fri, 26 Sep 2014 17:08:32 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:4430 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755908AbaIZVIb convert rfc822-to-8bit (ORCPT ); Fri, 26 Sep 2014 17:08:31 -0400 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Fri, 26 Sep 2014 14:08:34 -0700 Message-ID: <5425D5CD.4000002@nvidia.com> Date: Fri, 26 Sep 2014 14:08:29 -0700 From: Aaron Plattner User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Benjamin Herrenschmidt , Linus Torvalds CC: =?UTF-8?B?QyBCZXJnc3Ryw7Zt?= , Alex Williamson , DRI , Linux Kernel Mailing List Subject: Re: Stupid NVIDIA 3D vgaarb.c patch References: <1411504140.4184.26.camel@pasglop> In-Reply-To: <1411504140.4184.26.camel@pasglop> X-NVConfidentiality: public Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/23/2014 01:29 PM, Benjamin Herrenschmidt wrote: > On Mon, 2014-09-22 at 13:43 -0700, Linus Torvalds wrote: >> Adding proper people and mailing lists.. >> >> The PCI_CLASS_DISPLAY_VGA test goes back to the very beginning by >> BenH, and I have no idea if adding PCI_CLASS_DISPLAY_3D is >> appropriate, but hopefully somebody does. The fact that it makes >> things work certainly argues fairly convincingly for it, but I want >> some backup here. >> >> Dave, BenH? >> >> Christopher(?), can you please also specify which laptop etc. And the >> patch itself seems to have come from somebody else, unless you're >> Lekensteyn. So we'd want to get the provenance of that too. > > Hrm, that sucks. "3D" could mean anything really, we might need an > explicit vendor ID check as well and maybe even device ID ... If my understanding is correct, the board designers explicitly mark them as "3D controller" when they don't have any outputs connected, specifically so the SBIOS won't choose them as the boot VGA device. Depending on the design, some GPUs on these 3D controller boards don't have a display engine at all, while others still have it in the silicon but leave it disabled at runtime. In either case, VGA should not be routed to them and I don't think they should need to participate in VGA arbitration. -- Aaron > Ben. > >> Linus >> >> On Mon, Sep 22, 2014 at 1:28 PM, C Bergström wrote: >>> Hi Linus, >>> >>> I don't know who the original author is and I can have one of the distro >>> graphics friends review it, but I need this patch below to get NVIDIA >>> drivers to work (without using any Intel graphics) on my laptop >>> http://pastebin.com/wpmFi38k >>> >>> Sorry - I know this is not the proper way to submit a patch, but it's >>> trivial and I'm not a kernel dev. >>> >>> Thanks >>> >>> ./C