From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [RFC PATCH 6/7] drm/nouveau: Support marking buffers for explicit sync Date: Sat, 27 Sep 2014 08:52:20 +0200 Message-ID: <54265EA4.2010509@canonical.com> References: <1411725612-10455-1-git-send-email-lpeltonen@nvidia.com> <1411725612-10455-7-git-send-email-lpeltonen@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1411725612-10455-7-git-send-email-lpeltonen@nvidia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Lauri Peltonen , Ben Skeggs , Daniel Vetter , Colin Cross , Dave Airlie Cc: Stephen Warren , nouveau@lists.freedesktop.org, James Jones , dri-devel@lists.freedesktop.org, Thierry Reding , Ken Adams List-Id: nouveau.vger.kernel.org Hey, On 26-09-14 12:00, Lauri Peltonen wrote: > Do not attach fences automatically to buffers that are marked for > explicit synchronization. > > Signed-off-by: Lauri Peltonen > --- > drm/nouveau_bo.c | 8 ++++---- > drm/nouveau_bo.h | 4 ++-- > drm/nouveau_drm.c | 1 + > drm/nouveau_gem.c | 47 +++++++++++++++++++++++++++++++++++++++------- > drm/nouveau_gem.h | 6 ++++-- > drm/nouveau_ttm.c | 8 ++++---- > drm/nv50_display.c | 2 +- > drm/uapi/drm/nouveau_drm.h | 5 ++++- > 8 files changed, 60 insertions(+), 21 deletions(-) Considering this will break on eviction, is it really needed? If a fence is waited on before starting an operation synchronization will be a noop. ~Maarten