From: hujianyang <hujianyang@huawei.com>
To: <dedekind1@gmail.com>
Cc: linux-mtd <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH] UBIFS: Align the dump messages of SB_NODE
Date: Sun, 28 Sep 2014 09:58:17 +0800 [thread overview]
Message-ID: <54276B39.6000603@huawei.com> (raw)
In-Reply-To: <1411727765.23429.61.camel@sauron.fi.intel.com>
On 2014/9/26 18:36, Artem Bityutskiy wrote:
> On Sat, 2014-09-20 at 14:55 +0800, hujianyang wrote:
>> I found the dump messages of UBIFS_SB_NODE is not aligned. This
>> patch remove the extra space from the line which is retracted.
>>
>>
>> Signed-off-by: hujianyang <hujianyang@huawei.com>
>
> This was not a typo, this was intentional. We first print the all flags
> in a hex format, and then we "decode" it and print the values of the
> individual flags with an additional indent. The indent is to make it
> clear that these line belong to the flags, and they are not independent
> values.
>
Oh, thanks for your explanation~!
Hu
prev parent reply other threads:[~2014-09-28 1:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-20 6:55 [PATCH] UBIFS: Align the dump messages of SB_NODE hujianyang
2014-09-26 10:36 ` Artem Bityutskiy
2014-09-28 1:58 ` hujianyang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54276B39.6000603@huawei.com \
--to=hujianyang@huawei.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.