All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Akash Verma <akashv@google.com>, fio <fio@vger.kernel.org>
Cc: Allen Schade <aschade@google.com>
Subject: Re: If loops= is specified, zone state is unexpectedly retained across iterations.
Date: Sat, 27 Sep 2014 20:26:20 -0600	[thread overview]
Message-ID: <542771CC.9090203@kernel.dk> (raw)
In-Reply-To: <CAFFT=Ukkh3E7tkJkVQ09VMiribNtTt+ZKi8w3VRf7ovS5xw4ww@mail.gmail.com>

On 2014-09-25 11:36, Akash Verma wrote:
> Adding Jens on cc.
>
> On Tue, Sep 23, 2014 at 6:02 PM, Akash Verma <akashv@google.com> wrote:
>> I'm wondering if this is desired behavior or accidental. If I use this
>> control file:
>>
>> [sdb-zoned-and-looped]
>> rw=write
>> bs=4k
>> size=24k
>> zonesize=12k
>> zonerange=512k
>> zoneskip=512k
>> ioengine=sync
>> direct=1
>> thread=1
>> loops=10
>> filename=/dev/sdb
>> write_iolog=sdb_iolog.txt
>>
>> sdb_iolog.txt shows:
>> fio version 2 iolog
>> /dev/sdb add
>> /dev/sdb open
>> /dev/sdb write 0 4096
>> /dev/sdb write 4096 4096
>> /dev/sdb write 8192 4096
>> /dev/sdb write 1048576 4096
>> /dev/sdb write 1052672 4096
>> /dev/sdb write 1056768 4096
>> /dev/sdb close
>> /dev/sdb open
>> /dev/sdb write 1048576 4096
>> /dev/sdb write 1052672 4096
>> /dev/sdb write 1056768 4096
>> /dev/sdb write 2097152 4096
>> /dev/sdb write 2101248 4096
>> /dev/sdb write 2105344 4096
>> ...
>>
>> I'd expect each iteration of the loop to be identical, rather than
>> resuming from the zone offset of the previous iteration. Would it be
>> okay to change this behavior?

Yeah I think that would be OK, basically all state is cleared between 
loops, so I'd consider that a bug. The whole point of a loop is that 
they are supposed to be identical.

-- 
Jens Axboe



      reply	other threads:[~2014-09-28  2:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-24  1:02 If loops= is specified, zone state is unexpectedly retained across iterations Akash Verma
2014-09-25 17:36 ` Akash Verma
2014-09-28  2:26   ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=542771CC.9090203@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=akashv@google.com \
    --cc=aschade@google.com \
    --cc=fio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.