From: Johannes Sixt <j6t@kdbg.org>
To: Ben Walton <bdwalton@gmail.com>
Cc: karsten.blees@gmail.com, gitster@pobox.com, git@vger.kernel.org
Subject: Re: [PATCH] Do not make trace.c/getnanotime an inlined function
Date: Sun, 28 Sep 2014 21:15:29 +0200 [thread overview]
Message-ID: <54285E51.3090209@kdbg.org> (raw)
In-Reply-To: <1411890626-28237-1-git-send-email-bdwalton@gmail.com>
Am 28.09.2014 um 09:50 schrieb Ben Walton:
> Oracle Studio compilers don't allow for static variables in functions
> that are defined to be inline. GNU C does permit this. Let's reference
> the C99 standard though, which doesn't allow for inline functions to
> contain modifiable static variables.
>
> Signed-off-by: Ben Walton <bdwalton@gmail.com>
> ---
> trace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/trace.c b/trace.c
> index b6f25a2..4778608 100644
> --- a/trace.c
> +++ b/trace.c
> @@ -385,7 +385,7 @@ static inline uint64_t gettimeofday_nanos(void)
> * Returns nanoseconds since the epoch (01/01/1970), for performance tracing
> * (i.e. favoring high precision over wall clock time accuracy).
> */
> -inline uint64_t getnanotime(void)
> +uint64_t getnanotime(void)
> {
> static uint64_t offset;
> if (offset > 1) {
>
But then the function could stay static, no?
-- Hannes
next prev parent reply other threads:[~2014-09-28 19:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-28 7:50 [PATCH] Do not make trace.c/getnanotime an inlined function Ben Walton
2014-09-28 19:15 ` Johannes Sixt [this message]
[not found] ` <CAP30j14QGtHC7huU=3t4sJT_dZ3t9V=CBWyGyJW7EjT9H5ZK9w@mail.gmail.com>
2014-09-29 20:40 ` Johannes Sixt
2014-09-29 12:44 ` Duy Nguyen
2014-09-29 17:48 ` Junio C Hamano
2014-09-30 9:25 ` Duy Nguyen
2014-09-30 15:54 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54285E51.3090209@kdbg.org \
--to=j6t@kdbg.org \
--cc=bdwalton@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=karsten.blees@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.