From: Lars-Peter Clausen <lars@metafoo.de>
To: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>,
linux-kernel@vger.kernel.org
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH 2/2] ASoC: ssm2602: add support for 11.025kHz and 22.5kHz sample rates
Date: Mon, 29 Sep 2014 10:57:08 +0200 [thread overview]
Message-ID: <54291EE4.7030505@metafoo.de> (raw)
In-Reply-To: <1411891105-22683-1-git-send-email-stefan.kristiansson@saunalahti.fi>
On 09/28/2014 09:58 AM, Stefan Kristiansson wrote:
> This adds the necessary values to the constraint list and
> register values to the coefficient table in order to
> configure the device for 11.025kHz and 22.5kHz sample rates.
>
> Signed-off-by: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks.
But again, don't forget to Cc the ASoC maintainers, otherwise the patch will
be lost.
[...]
> @@ -467,7 +477,8 @@ static int ssm2602_set_bias_level(struct snd_soc_codec *codec,
> return 0;
> }
>
> -#define SSM2602_RATES (SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000 |\
> +#define SSM2602_RATES (SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_11025 |\
> + SNDRV_PCM_RATE_22050 | SNDRV_PCM_RATE_16000 |\
Tiny nitpick, order should be SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_22050 to
keep things sorted.
> SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_44100 |\
> SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_88200 |\
> SNDRV_PCM_RATE_96000)
>
prev parent reply other threads:[~2014-09-29 8:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-28 7:58 [PATCH 2/2] ASoC: ssm2602: add support for 11.025kHz and 22.5kHz sample rates Stefan Kristiansson
2014-09-29 8:57 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54291EE4.7030505@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stefan.kristiansson@saunalahti.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.