From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Grinberg Subject: Re: [PATCH v3] ARM: DT: apq8064: add CM-QS600 board Date: Mon, 29 Sep 2014 12:35:22 +0300 Message-ID: <542927DA.9010507@compulab.co.il> References: <1411749127-12746-1-git-send-email-mike.rapoport@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from softlayer.compulab.co.il ([50.23.254.55]:39889 "EHLO compulab.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752684AbaI2Jf0 (ORCPT ); Mon, 29 Sep 2014 05:35:26 -0400 In-Reply-To: <1411749127-12746-1-git-send-email-mike.rapoport@gmail.com> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Mike Rapoport , Kumar Gala Cc: linux-arm-msm@vger.kernel.org, Srinivas Kandagatla , Bjorn Andersson , linux-arm-kernel@lists.infradead.org Hi Mike, On 09/26/14 19:32, Mike Rapoport wrote: > CM-QS600 is a APQ8064 based computer on module. > The details are available at > http://compulab.co.il/products/computer-on-modules/cm-qs600/ > > Signed-off-by: Mike Rapoport Thanks for working on this! Some minor notes... Can we have the subject aligned with other submissions, e.g. ARM: dts: qcom: ... ? > --- > v2 changes: duplicate the settings for the cm-qs600 board in its .dts file as Kumar suggested > v3 changes: add board details and keep dts Makefile sorted alphabetically [...] > new file mode 100644 > index 0000000..db7cf03 > --- /dev/null > +++ b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts > @@ -0,0 +1,59 @@ [...] > + eeprom: eeprom@52 { > + compatible = "atmel,24c128"; I believe the above should be 24c02. And the address is 0x50. > + reg = <0x52>; > + pagesize = <32>; pagesize is 16. [...] Apart from the eeprom stuff above: Acked-by: Igor Grinberg -- Regards, Igor. From mboxrd@z Thu Jan 1 00:00:00 1970 From: grinberg@compulab.co.il (Igor Grinberg) Date: Mon, 29 Sep 2014 12:35:22 +0300 Subject: [PATCH v3] ARM: DT: apq8064: add CM-QS600 board In-Reply-To: <1411749127-12746-1-git-send-email-mike.rapoport@gmail.com> References: <1411749127-12746-1-git-send-email-mike.rapoport@gmail.com> Message-ID: <542927DA.9010507@compulab.co.il> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Mike, On 09/26/14 19:32, Mike Rapoport wrote: > CM-QS600 is a APQ8064 based computer on module. > The details are available at > http://compulab.co.il/products/computer-on-modules/cm-qs600/ > > Signed-off-by: Mike Rapoport Thanks for working on this! Some minor notes... Can we have the subject aligned with other submissions, e.g. ARM: dts: qcom: ... ? > --- > v2 changes: duplicate the settings for the cm-qs600 board in its .dts file as Kumar suggested > v3 changes: add board details and keep dts Makefile sorted alphabetically [...] > new file mode 100644 > index 0000000..db7cf03 > --- /dev/null > +++ b/arch/arm/boot/dts/qcom-apq8064-cm-qs600.dts > @@ -0,0 +1,59 @@ [...] > + eeprom: eeprom at 52 { > + compatible = "atmel,24c128"; I believe the above should be 24c02. And the address is 0x50. > + reg = <0x52>; > + pagesize = <32>; pagesize is 16. [...] Apart from the eeprom stuff above: Acked-by: Igor Grinberg -- Regards, Igor.