From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Kandagatla Subject: Re: [PATCH 3/4] ARM: DT: apq8064: Add USB OTG support Date: Mon, 29 Sep 2014 12:27:58 +0100 Message-ID: <5429423E.8030908@linaro.org> References: <1411982044-7873-1-git-send-email-srinivas.kandagatla@linaro.org> <1411982127-8048-1-git-send-email-srinivas.kandagatla@linaro.org> <542933E1.8010809@smartplayin.com> <20140929105329.GA2432@leverpostej> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f176.google.com ([74.125.82.176]:37963 "EHLO mail-we0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751856AbaI2L2B (ORCPT ); Mon, 29 Sep 2014 07:28:01 -0400 Received: by mail-we0-f176.google.com with SMTP id p10so1251146wes.21 for ; Mon, 29 Sep 2014 04:28:00 -0700 (PDT) In-Reply-To: <20140929105329.GA2432@leverpostej> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Mark Rutland , Kiran Padwal Cc: Kumar Gala , "devicetree@vger.kernel.org" , "broonie@kernel.org" , "lee.jones@linaro.org" , Rob Herring , Pawel Moll , Ian Campbell , Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "arm@kernel.org" , "linux-arm-msm@vger.kernel.org" , "bjorn.andersson@sonymobile.com" On 29/09/14 11:53, Mark Rutland wrote: >> >Its canonical value is "okay" (although in practice anything >> >other than "disabled" should work). > That's not quite true, there are other "bad" values like "fail" and > "fail-sss" documented by ePAPR. In Linux, of_device_is_available errs on > the side of caution and checks for either "okay" or "ok", failing > otherwise > > Regardless, please use the canonical "okay". I will fix this in v2. --srini From mboxrd@z Thu Jan 1 00:00:00 1970 From: srinivas.kandagatla@linaro.org (Srinivas Kandagatla) Date: Mon, 29 Sep 2014 12:27:58 +0100 Subject: [PATCH 3/4] ARM: DT: apq8064: Add USB OTG support In-Reply-To: <20140929105329.GA2432@leverpostej> References: <1411982044-7873-1-git-send-email-srinivas.kandagatla@linaro.org> <1411982127-8048-1-git-send-email-srinivas.kandagatla@linaro.org> <542933E1.8010809@smartplayin.com> <20140929105329.GA2432@leverpostej> Message-ID: <5429423E.8030908@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 29/09/14 11:53, Mark Rutland wrote: >> >Its canonical value is "okay" (although in practice anything >> >other than "disabled" should work). > That's not quite true, there are other "bad" values like "fail" and > "fail-sss" documented by ePAPR. In Linux, of_device_is_available errs on > the side of caution and checks for either "okay" or "ok", failing > otherwise > > Regardless, please use the canonical "okay". I will fix this in v2. --srini