From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cantor2.suse.de ([195.135.220.15]:35152 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754143AbaI2Olq (ORCPT ); Mon, 29 Sep 2014 10:41:46 -0400 Message-ID: <54296FA3.8080902@suse.cz> Date: Mon, 29 Sep 2014 16:41:39 +0200 From: Michal Marek MIME-Version: 1.0 Subject: Re: [PATCH 1/1] [RFC] kconfig: warn if an unknown symbol is selected References: <1411769309.15241.37.camel@x220> In-Reply-To: <1411769309.15241.37.camel@x220> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Paul Bolle Cc: "Yann E. MORIN" , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org On 2014-09-27 00:08, Paul Bolle wrote: > A select of an unknown symbol is basically treated as a nop and is > silently skipped. This is annoying if the selected symbol contains a > typo. It can also hide the fact that a treewide symbol cleanup was only > done partially. > > There are also a few cases were this might have been done on purpose. > But that anti-pattern should be discouraged. Almost all select > statements point to a known and reachable symbol. So people will likely > assume that any selected symbol is actually set. Violating that > assumption might lead to (subtle) bugs. > > So let's warn when we notice a select of a symbol that is not known in > the configuration we're creating. > > Rfced-by: Paul Bolle I think this is a good idea, it fits well next to the already present warning about selecting symbols with unmet dependencies. Feel free to submit as a regular patch with Acked-by: Michal Marek Michal