From: David L Stevens <david.stevens@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, sowmini.varadhan@oracle.com,
raghuram.kothakota@oracle.com
Subject: Re: [PATCHv8 net-next 2/4] sunvnet: make transmit path zero-copy in the kernel
Date: Mon, 29 Sep 2014 16:44:08 -0400 [thread overview]
Message-ID: <5429C498.1000705@oracle.com> (raw)
In-Reply-To: <20140929.162950.1960056644564225055.davem@davemloft.net>
On 09/29/2014 04:29 PM, David Miller wrote:
>
> It doesn't work to liberate SKBs in the TX ring purely from the
> ->ndo_start_xmit() method.
>
> All SKBs given to a device must be liberated in a finite, short,
> amount of time.
I did consider putting a garbage-collector via timer on them, since
we got such a boost from not ACKing every packet. I guess the question
is "how short?"
For example, I could leave the "normal" path like this and just start/mod
a timer to do it after 1 sec if we haven't done it through start_xmit. Do
you think that's sufficiently short?
+-DLS
next prev parent reply other threads:[~2014-09-29 20:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 19:54 [PATCHv8 net-next 2/4] sunvnet: make transmit path zero-copy in the kernel David L Stevens
2014-09-29 20:29 ` David Miller
2014-09-29 20:44 ` David L Stevens [this message]
2014-09-29 20:54 ` David Miller
2014-09-29 21:02 ` David L Stevens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5429C498.1000705@oracle.com \
--to=david.stevens@oracle.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=raghuram.kothakota@oracle.com \
--cc=sowmini.varadhan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.