All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
To: linux-media@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>
Subject: Regression: in v4l2 converter does not set the buffer.length anymore
Date: Mon, 29 Sep 2014 17:23:34 -0400	[thread overview]
Message-ID: <5429CDD6.9050809@collabora.com> (raw)

This was initially reported to GStreamer project:
https://bugzilla.gnome.org/show_bug.cgi?id=737521

We track this down to be a regression introduced in v4l2-utils from 
version 1.4.0. In recent GStreamer we make sure the buffer.length field 
(retreived with QUERYBUF) is bigger or equal to the expected sizeimage 
(as obtained in S_FMT). This is to fail cleanly and avoid buffer 
overflow if a driver (or libv4l2) endup doing a short allocation. Since 
1.4.0, this field is always 0 if an emulated format is selected.

Reverting patch 10213c brings back normal behaviour:
http://git.linuxtv.org/cgit.cgi/v4l-utils.git/commit/?id=10213c975afdfcc90aa7de39e66c40cd7e8a57f7

This currently makes use of any emulated format impossible in GStreamer. 
v4l2-utils 1.4.0 is being shipped at least in debian/unstable at the moment.

cheers,
Nicolas

             reply	other threads:[~2014-09-29 21:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-29 21:23 Nicolas Dufresne [this message]
2014-09-30 14:04 ` Regression: in v4l2 converter does not set the buffer.length anymore Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5429CDD6.9050809@collabora.com \
    --to=nicolas.dufresne@collabora.com \
    --cc=hdegoede@redhat.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.