From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37329) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYltY-0006Hq-8I for qemu-devel@nongnu.org; Mon, 29 Sep 2014 21:06:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYltQ-0006j2-3a for qemu-devel@nongnu.org; Mon, 29 Sep 2014 21:06:24 -0400 Received: from omzsmtpe04.verizonbusiness.com ([199.249.25.207]:26429) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYltP-0006i6-Uk for qemu-devel@nongnu.org; Mon, 29 Sep 2014 21:06:16 -0400 From: Don Slutz Message-ID: <542A01C3.70908@terremark.com> Date: Mon, 29 Sep 2014 21:05:07 -0400 MIME-Version: 1.0 References: <1411757235-29128-1-git-send-email-dslutz@verizon.com> <1411757235-29128-2-git-send-email-dslutz@verizon.com> <54291463.1080205@suse.de> <54293E24.3080205@redhat.com> <54294832.9060001@suse.de> <54294ECF.1040705@redhat.com> <54295728.5080203@suse.de> <54295B38.6020105@redhat.com> In-Reply-To: <54295B38.6020105@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Alexander Graf , Don Slutz , qemu-devel@nongnu.org Cc: xen-devel@lists.xensource.com, Marcel Apfelbaum , "Michael S. Tsirkin" , Markus Armbruster , Anthony Liguori , =?windows-1252?Q?Andreas_F=E4rber?= , Stefano Stabellini On 09/29/14 09:14, Paolo Bonzini wrote: > Il 29/09/2014 14:57, Alexander Graf ha scritto: >>>> Yeah, that would be possible. You do not even need synchronize_state, >>>> it seems to me that it introduces more complication for little gain. >> Well, it makes all accels behave the same and keep information always at >> a single entity (the env struct). I don't think the vmport code should >> have knowledge of a xen env struct. > Yes, we agree on that. In fact the right CPU is already stored in > send_vcpu of XenIOState. I did reply up the thread because the info is missing here. Basically current_cpu is NULL here, and I think that no CPU objects have been created for Xen. So there is no VCPU object to select. -Don Slutz > Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 From: Don Slutz Subject: Re: [PATCH 1/1] xen-hvm.c: Add support for Xen access to vmport Date: Mon, 29 Sep 2014 21:05:07 -0400 Message-ID: <542A01C3.70908@terremark.com> References: <1411757235-29128-1-git-send-email-dslutz@verizon.com> <1411757235-29128-2-git-send-email-dslutz@verizon.com> <54291463.1080205@suse.de> <54293E24.3080205@redhat.com> <54294832.9060001@suse.de> <54294ECF.1040705@redhat.com> <54295728.5080203@suse.de> <54295B38.6020105@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54295B38.6020105@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Paolo Bonzini , Alexander Graf , Don Slutz , qemu-devel@nongnu.org Cc: xen-devel@lists.xensource.com, Marcel Apfelbaum , "Michael S. Tsirkin" , Markus Armbruster , Anthony Liguori , =?windows-1252?Q?Andreas_F=E4rber?= , Stefano Stabellini List-Id: xen-devel@lists.xenproject.org On 09/29/14 09:14, Paolo Bonzini wrote: > Il 29/09/2014 14:57, Alexander Graf ha scritto: >>>> Yeah, that would be possible. You do not even need synchronize_state, >>>> it seems to me that it introduces more complication for little gain. >> Well, it makes all accels behave the same and keep information always at >> a single entity (the env struct). I don't think the vmport code should >> have knowledge of a xen env struct. > Yes, we agree on that. In fact the right CPU is already stored in > send_vcpu of XenIOState. I did reply up the thread because the info is missing here. Basically current_cpu is NULL here, and I think that no CPU objects have been created for Xen. So there is no VCPU object to select. -Don Slutz > Paolo