All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 1/2] ARM: rpi_b: query internal MAC address from firmware
Date: Mon, 29 Sep 2014 22:21:46 -0600	[thread overview]
Message-ID: <542A2FDA.3020503@wwwdotorg.org> (raw)
In-Reply-To: <201409272143.19598.marex@denx.de>

On 09/27/2014 01:43 PM, Marek Vasut wrote:
> On Saturday, September 27, 2014 at 04:51:39 AM, Stephen Warren wrote:
>> The built-in SMSC 95xx chip doesn't know its own MAC address. Instead,
>> we must query it from the VC firmware; it's probably encoded in fuses
>> on the BCM2835.
>>
>> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
>> ---
>> v2: Don't set usbethaddr if it's already set
>> ---
>>  arch/arm/include/asm/arch-bcm2835/mbox.h | 14 ++++++++++++++
>>  board/raspberrypi/rpi_b/rpi_b.c          | 29
>> +++++++++++++++++++++++++++++ include/configs/rpi_b.h                  | 
>> 1 +
>>  3 files changed, 44 insertions(+)
>>
>> diff --git a/arch/arm/include/asm/arch-bcm2835/mbox.h
>> b/arch/arm/include/asm/arch-bcm2835/mbox.h index dded857..61f427d 100644
>> --- a/arch/arm/include/asm/arch-bcm2835/mbox.h
>> +++ b/arch/arm/include/asm/arch-bcm2835/mbox.h
>> @@ -119,6 +119,20 @@ struct bcm2835_mbox_tag_hdr {
>>   * };
>>   */
>>
>> +#define BCM2835_MBOX_TAG_GET_MAC_ADDRESS	0x00010003
>> +
>> +struct bcm2835_mbox_tag_get_mac_address {
>> +	struct bcm2835_mbox_tag_hdr tag_hdr;
>> +	union {
>> +		struct {
>> +		} req;
>> +		struct {
>> +			u8 mac[6];
>> +			u8 pad[2];
>> +		} resp;
> 
> Well, can't this be a simple u32 here ?

If you ignore the fact the message format really is 6 individual bytes,
sure:-P.

> [...]
> 
> Who will pick this series , shall I pick it ?

That sounds reasonable to me; they depend on your patches. I suppose
Albert might want to ack that.

  reply	other threads:[~2014-09-30  4:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-27  2:51 [U-Boot] [PATCH V2 1/2] ARM: rpi_b: query internal MAC address from firmware Stephen Warren
2014-09-27  2:51 ` [U-Boot] [PATCH 2/2] ARM: rpi_b: enable USB/DHCP/PXE in bootcmd Stephen Warren
2014-09-27 19:43 ` [U-Boot] [PATCH V2 1/2] ARM: rpi_b: query internal MAC address from firmware Marek Vasut
2014-09-30  4:21   ` Stephen Warren [this message]
2014-09-30 12:49     ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=542A2FDA.3020503@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.