From: Juergen Gross <jgross@suse.com>
To: Chen Gang <gang.chen.5i5j@gmail.com>,
David Vrabel <david.vrabel@citrix.com>,
Jan Beulich <JBeulich@suse.com>
Cc: xen-devel@lists.xenproject.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH] xen/xen-scsiback: Need go to fail after xenbus_dev_error()
Date: Tue, 30 Sep 2014 08:59:34 +0200 [thread overview]
Message-ID: <542A54D6.8070906@suse.com> (raw)
In-Reply-To: <542A4E79.4020109@gmail.com>
On 09/30/2014 08:32 AM, Chen Gang wrote:
> On 9/29/14 21:57, David Vrabel wrote:
>> On 29/09/14 10:59, Chen Gang wrote:
>>>
>>>
>>> If no any additional reply within 2 days, I shall send patch v2 for it:
>>>
>>> "use dev_warn() instead of xenbus_dev_error() and remove 'fail' code block"
>>
>> I think this driver is fine as-is and does not need any changes.
>>
>
> OK, at least, at present, it is not a bug (will cause any issue).
>
> But for me, xenbus_dev_error() seems for printing generic errors,
> dev_warn() is more suitable than it.
I'm unbiased regarding this one.
>
> And 'fail' code block is useless now, need be removed, too (which will
> let compiler report warning).
This should be part of the patch making the 'fail' block useless.
Juergen
next prev parent reply other threads:[~2014-09-30 6:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 16:38 [PATCH] xen/xen-scsiback: Need go to fail after xenbus_dev_error() Chen Gang
2014-09-29 4:32 ` [Xen-devel] " Juergen Gross
2014-09-29 8:41 ` Jan Beulich
2014-09-29 8:41 ` [Xen-devel] " Jan Beulich
2014-09-29 9:31 ` Chen Gang
2014-09-29 9:34 ` Juergen Gross
2014-09-29 9:59 ` Chen Gang
2014-09-29 9:59 ` [Xen-devel] " Chen Gang
2014-09-29 13:57 ` David Vrabel
2014-09-30 6:32 ` Chen Gang
2014-09-30 6:59 ` Juergen Gross
2014-09-30 6:59 ` Juergen Gross [this message]
2014-09-30 7:50 ` Chen Gang
2014-09-30 7:50 ` [Xen-devel] " Chen Gang
2014-09-30 10:23 ` Chen Gang
2014-09-30 10:23 ` [Xen-devel] " Chen Gang
2014-09-30 6:32 ` Chen Gang
2014-09-29 13:57 ` David Vrabel
2014-09-29 9:34 ` Juergen Gross
2014-09-29 9:31 ` Chen Gang
2014-09-29 4:32 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542A54D6.8070906@suse.com \
--to=jgross@suse.com \
--cc=JBeulich@suse.com \
--cc=david.vrabel@citrix.com \
--cc=gang.chen.5i5j@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.