From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tanya Brokhman Subject: Re: [PATCH] mtd: ubi: Extend UBI layer debug/messaging capabilities Date: Tue, 30 Sep 2014 10:30:00 +0300 Message-ID: <542A5BF8.3030103@codeaurora.org> References: <1411886185-7838-1-git-send-email-tlinder@codeaurora.org> <54293975.9040402@gmail.com> <54294A01.8070505@nod.at> <54295165.4030201@smartplayin.com> <54295274.4020805@nod.at> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from smtp.codeaurora.org ([198.145.11.231]:49517 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750791AbaI3HaF (ORCPT ); Tue, 30 Sep 2014 03:30:05 -0400 In-Reply-To: <54295274.4020805@nod.at> Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Richard Weinberger , Kiran Padwal Cc: Artem Bityutskiy , linux-arm-msm@vger.kernel.org, open list , linux-mtd@lists.infradead.org, Kiran Padwal , Brian Norris , David Woodhouse On 9/29/2014 3:37 PM, Richard Weinberger wrote: > Am 29.09.2014 14:32, schrieb Kiran Padwal: >> On Monday 29 September 2014 05:31 PM, Richard Weinberger wrote: >>> Am 29.09.2014 12:50, schrieb Kiran Padwal: >>>> Hi Tanya, >>>> >>>> On Sunday 28 September 2014 12:06 PM, Tanya Brokhman wrote: >>>>> If there is more then one UBI device mounted, there is no way to >>>>> distinguish between messages from different UBI devices. >>>>> Add device number to all ubi layer message types. >>>>> >>>>> >>>>> Signed-off-by: Tanya Brokhman >>>>> >>>>> --- >>>>> drivers/mtd/ubi/attach.c | 138 ++++++++++++++++++++-----------= ----- >>>>> drivers/mtd/ubi/build.c | 130 ++++++++++++++++++++-----------= --- >>>>> drivers/mtd/ubi/cdev.c | 37 +++++----- >>>>> drivers/mtd/ubi/debug.c | 9 +-- >>>>> drivers/mtd/ubi/eba.c | 54 +++++++------- >>>>> drivers/mtd/ubi/fastmap.c | 108 ++++++++++++++++------------ >>>>> drivers/mtd/ubi/io.c | 177 +++++++++++++++++++++++++++----= --------------- >>>>> drivers/mtd/ubi/kapi.c | 6 +- >>>>> drivers/mtd/ubi/misc.c | 6 +- >>>>> drivers/mtd/ubi/ubi.h | 13 ++-- >>>>> drivers/mtd/ubi/vmt.c | 76 +++++++++++--------- >>>>> drivers/mtd/ubi/vtbl.c | 54 ++++++++------ >>>>> drivers/mtd/ubi/wl.c | 87 +++++++++++++++-------- >>>>> 13 files changed, 521 insertions(+), 374 deletions(-) >>>> >>>> Compilation breaks while I try to compile with this patch. >>>> May be you need to update remaining ubi layer messages also. >>> >>> Please always share the errors you face. >>> Maybe you have a different config. >> >> Sure, I will take care of this next time. >> >> Macros have been changed but some instances of older macros still re= mained, which caused many errors like, >> >> drivers/mtd/ubi/build.c: In function =91ubi_init=92: >> drivers/mtd/ubi/build.c:1322:49: error: expected =91)=92 before =91e= rr=92 >> ubi_err("block: cannot initialize, error %d", err); > > Ohh. :( > Tanya, did you test your patch? > Of course I did. I used nandsimulator on a virtual machine to test all=20 patches. Perhaps my error was testing them all together (with=20 read-disturb) and this got lost somehow. It's very strange you got=20 compilation errors. I'm sorry for the inconvenience. Will look into thi= s=20 today and upload a new version ASAP. (with all previous comments=20 addressed as well) > Thanks, > //richard > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/ > --=20 Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,=20 hosted by The Linux Foundation