From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f41.google.com ([209.85.220.41]:57003 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbaI3JN0 (ORCPT ); Tue, 30 Sep 2014 05:13:26 -0400 Received: by mail-pa0-f41.google.com with SMTP id eu11so3868564pac.0 for ; Tue, 30 Sep 2014 02:13:26 -0700 (PDT) Message-ID: <542A73A3.5010705@gmail.com> Date: Tue, 30 Sep 2014 14:40:59 +0530 From: Varka Bhadram MIME-Version: 1.0 Subject: Re: ICMPv6 Redirects References: <20140929133048.GB14608@omega> <54295FA9.8030506@xsilon.com> <20140929133841.GA15176@omega> <542963F7.4030903@xsilon.com> <20140929135759.GA15411@omega> <542968C5.7000505@xsilon.com> <20140929164157.GA17633@omega> <542A6B15.7060203@xsilon.com> <20140930083835.GA20280@omega> <542A6DF6.809@gmail.com> <20140930085347.GA28060@omega> In-Reply-To: <20140930085347.GA28060@omega> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-wpan-owner@vger.kernel.org List-ID: To: Alexander Aring Cc: Simon Vincent , linux-wpan@vger.kernel.org, jukka.rissanen@linux.intel.com Hi Alex, On 09/30/2014 02:23 PM, Alexander Aring wrote: > Hi Varka, > > On Tue, Sep 30, 2014 at 02:16:46PM +0530, Varka Bhadram wrote: >> Alex, >> >> On 09/30/2014 02:09 PM, Alexander Aring wrote: >>> On Tue, Sep 30, 2014 at 09:34:29AM +0100, Simon Vincent wrote: >>>> I can confirm that this fixes the problem. I will create some patches when I >>>> get a chance. >>>> Thanks >>>> >>> This should make trouble on phy's which have no address filter... >> I didnt get what do you mean by this..? >> > The mac802154 address filter sets PACKET_BROADCAST, PACKET_HOST and > PACKET_OTHERHOST. When you have an address filter on PHY, then > PACKET_OTHERHOST should never happen (on good phy's). > > So you always set PACKET_HOST xor PACKET_BROADCAST. Enabling address filtering is in drivers hand.. Few hardware devices may not be handling the address filtering (SOftMAC devices). So we need take care of this at Software layers. >>> But when IPv6 Layer look on PACKET_BROADCAST then this is also another >>> bug... >>> >>> I did a grep: >>> >>> grep -r "PACKET_BROADCAST" net/IPv6 >>> >>> matches on: >>> >>> net/ipv6/mcast.c: skb->pkt_type != PACKET_BROADCAST) > 6LoWPAN layer always override the mac802154 parse value to PACKET_HOST. > Now I want to check if IPv6 Layer ever evaluate this value to > PACKET_BROADCAST and yes it seems so. So there is some other bug which > nobody detected. > > Ok? 6LoWPAN layer override the mac802154 parse value to PACKET_HOST, but that you only fixed yesterday. Now we need not to worry about override. Here we need to consider one point. IPv6 layer deals with MUTICAST addresses, there is no broadcast address at this pint. MAC802154 deals with BROADCAST addresses...? What is the bug that you are talking about..? > - Alex -- Regards, Varka Bhadram.