Re: Some oxenstored improvements (v3)

[Zheng Li <dev@zheng.li>]

On 29/09/2014 21:55, Dave Scott wrote:
> I’ve just read through the v3 patches and am happy with them. So I’m happy to give them an
>
>    Acked-by: David Scott <dave.scott@citrix.com>
>
> I think this patch:
>
> [PATCH v3 4/9] oxenstored: catch the error when a connection is already deleted
>
> is a useful bug fix — this might explain why oxenstored has occasionally ‘disappeared’ in mysterious circumstances. Zheng: could this patch be taken by itself? If so I think the release should definitely have it.

Yes, [4/9] can be picked up by itself. It's a small patch and should be quite safe.

> The rest of the patches will help scalability a lot but aren’t critical fixes. They would (IMHO) increase the quality of the release though.

To group the these patches:

   * [1/9], [2/9], and [3/9], are about select -> poll;
   * [7/9] and [8/9] are about exhaustive ring scan -> selective ring scan, with [5/9] and [6/9] adding some facilities.
   * [4/9] is a solo bug fix patch as stated;
   * [9/9] is a solo perf improvement patch on syslog load.

Cheers,
Zheng

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel