From: Douglas Gilbert <dgilbert@interlog.com>
To: Christoph Hellwig <hch@lst.de>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/2] sg: fix sparse __user annotation warning
Date: Tue, 30 Sep 2014 11:54:00 -0400 [thread overview]
Message-ID: <542AD218.1090808@interlog.com> (raw)
In-Reply-To: <1412090405-24436-1-git-send-email-hch@lst.de>
On 14-09-30 11:20 AM, Christoph Hellwig wrote:
> blk_trace_setup takes a __user pointer, so use the local void __user *
> pointer instead of casting the argument to char * for it in the sg
> ioctl handler.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Douglas Gilbert <dgilbert@interlog.com>
> ---
> drivers/scsi/sg.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
> index 01cf888..b94435b 100644
> --- a/drivers/scsi/sg.c
> +++ b/drivers/scsi/sg.c
> @@ -1138,7 +1138,7 @@ sg_ioctl(struct file *filp, unsigned int cmd_in, unsigned long arg)
> sdp->disk->disk_name,
> MKDEV(SCSI_GENERIC_MAJOR, sdp->index),
> NULL,
> - (char *)arg);
> + p);
> case BLKTRACESTART:
> return blk_trace_startstop(sdp->device->request_queue, 1);
> case BLKTRACESTOP:
>
prev parent reply other threads:[~2014-09-30 15:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 15:20 [PATCH 1/2] sg: fix sparse __user annotation warning Christoph Hellwig
2014-09-30 15:20 ` [PATCH 2/2] scsi: add a CONFIG_SCSI_MQ_DEFAULT option Christoph Hellwig
2014-09-30 15:54 ` Douglas Gilbert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542AD218.1090808@interlog.com \
--to=dgilbert@interlog.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.