All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Jeff Cody <jcody@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] qapi: Add corrupt field to ImageInfoSpecificQCow2
Date: Tue, 30 Sep 2014 14:17:00 -0600	[thread overview]
Message-ID: <542B0FBC.8010603@redhat.com> (raw)
In-Reply-To: <1412105489-7681-3-git-send-email-mreitz@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 954 bytes --]

On 09/30/2014 01:31 PM, Max Reitz wrote:
> Just like lazy-refcounts, this field will be present iff the qcow2
> compat level is 1.1 (or probably any future revision).
> 
> As expected, this breaks some tests due to the new field present in
> qemu-img info output; so fix their output accordingly.
> 
> Suggested-by: Eric Blake <eblake@redhat.com>

Thanks for tackling this :)

> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
>  block/qcow2.c              |  3 +++
>  qapi/block-core.json       |  6 +++++-
>  tests/qemu-iotests/065     | 12 ++++++------
>  tests/qemu-iotests/067.out | 10 +++++-----
>  tests/qemu-iotests/082.out |  7 +++++++
>  tests/qemu-iotests/089.out |  2 ++
>  6 files changed, 28 insertions(+), 12 deletions(-)
> 

Reviewed-by: Eric Blake <eblake@redhat.com>

(those are some long lines!)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]

  reply	other threads:[~2014-09-30 20:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-30 19:31 [Qemu-devel] [PATCH 0/3] qcow2/qapi: Add "corrupt" to ImageInfoSpecificQCow2 Max Reitz
2014-09-30 19:31 ` [Qemu-devel] [PATCH 1/3] iotests: Use _img_info Max Reitz
2014-09-30 20:14   ` Eric Blake
2014-09-30 19:31 ` [Qemu-devel] [PATCH 2/3] qapi: Add corrupt field to ImageInfoSpecificQCow2 Max Reitz
2014-09-30 20:17   ` Eric Blake [this message]
2014-09-30 19:31 ` [Qemu-devel] [PATCH 3/3] iotests: qemu-img info output for corrupt image Max Reitz
2014-09-30 20:21   ` Eric Blake
2014-10-04 18:18 ` [Qemu-devel] [PATCH 0/3] qcow2/qapi: Add "corrupt" to ImageInfoSpecificQCow2 Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=542B0FBC.8010603@redhat.com \
    --to=eblake@redhat.com \
    --cc=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.