From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34604)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XZ5mZ-0006Mx-7J
	for qemu-devel@nongnu.org; Tue, 30 Sep 2014 18:20:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XZ5mP-000274-U5
	for qemu-devel@nongnu.org; Tue, 30 Sep 2014 18:20:30 -0400
Received: from mail-wg0-x22b.google.com ([2a00:1450:400c:c00::22b]:48448)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1XZ5mP-00026f-KD
	for qemu-devel@nongnu.org; Tue, 30 Sep 2014 18:20:21 -0400
Received: by mail-wg0-f43.google.com with SMTP id a1so4729222wgh.2
	for <qemu-devel@nongnu.org>; Tue, 30 Sep 2014 15:20:20 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <542B2CA2.5030900@redhat.com>
Date: Wed, 01 Oct 2014 00:20:18 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1412101566-23669-1-git-send-email-ehabkost@redhat.com>
	<1412101566-23669-5-git-send-email-ehabkost@redhat.com>
In-Reply-To: <1412101566-23669-5-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 4/7] tests: Add unit test for X86CPU code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: Igor Mammedov <imammedo@redhat.com>, =?windows-1252?Q?Andreas_F=E4rber?= <afaerber@suse.de>

Il 30/09/2014 20:26, Eduardo Habkost ha scritto:
> Reasoning for each object file included in the test binary:
>  * qom/cpu.o - for TYPE_CPU. Dependencies:
>    * qom/qom-qobject.o
>  * qom/qdev.o - for TYPE_DEVICE. Dependencies:
>    * qom/container.o
>    * vmstate.o. Dependencies:
>      * qemu-file.o
>    * hw/core/hotplug.o
>    * hw/core/irq.o
>    * hw/core/fw-path-provider.o
>    * hw/core/qdev-properties.o
>  * qom/object.o - for TYPE_OBJECT
>  * x86_64-softmmu/target-i386/machine.o - for vmstate_x86_cpu
>  * qemu-log.o - for the logging API, used by target-i386/cpu.c
>  * libqemuutil.a - for QAPI visitors, error API, and other symbols
>  * libqemustub.a - existing stubs, including: savevm, monitor symbols
> 
> The remaining symbols used by target-i386/cpu.c were added as stubs to
> either tests/vl-stub.c and tests/x86-stub.c.

Nice.  Luckily qemu-log.o doesn't bring in everything.

I think vl-stub.c has to be re-evaluated after your QOM accelerator
patch goes in.

tests/x86-stub.c perhaps can be moved to target-i386/test-stubs.c?

Paolo