All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rick Jones <rick.jones2@hp.com>
To: netdev@vger.kernel.org
Subject: Philosophical question:  Is a UDP multicast datagram for which there is no socket match a drop or an ignore?
Date: Tue, 30 Sep 2014 16:09:37 -0700	[thread overview]
Message-ID: <542B3831.5030701@hp.com> (raw)

I've been looking at some additional perf <mutter> -e skb_kfree_skb 
results, this time with a laptop connected to a corporate network with a 
large number of Windows systems sending out what they are wont to 
send...  The laptop is just sitting there no active netperfs or anything :)

I see profile hits for __udp4_lib_mcast_deliver() which has a 
kfree_skb() call which will happen if either there were no sockets 
found, or if an integral multiple of ARRAY_SIZE(stack) sockets are 
found.  I'm assuming the latter is exceedingly rare.

Anywho, the philosophical question - is such a situation a drop 
(indicating the existing kfree_skb()), or is it an ignore (indicating a 
consume_skb())?  Should there be a statistic incremented for either of 
those?

happy benchmarking,

rick jones

             reply	other threads:[~2014-09-30 23:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-30 23:09 Rick Jones [this message]
2014-09-30 23:23 ` Philosophical question: Is a UDP multicast datagram for which there is no socket match a drop or an ignore? Eric Dumazet
2014-10-01  0:22   ` Rick Jones
2014-10-01  0:29     ` Eric Dumazet
2014-10-01  0:31       ` Rick Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=542B3831.5030701@hp.com \
    --to=rick.jones2@hp.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.