All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Bryan O'Donoghue" <pure.logic@nexus-software.ie>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: mingo@redhat.com, hpa@zytor.com, davej@redhat.com,
	hmh@hmh.eng.br, x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] x86: Quark: Add legacy_cache_size and TLB comments
Date: Wed, 01 Oct 2014 01:30:14 +0100	[thread overview]
Message-ID: <542B4B16.6060401@nexus-software.ie> (raw)
In-Reply-To: <alpine.DEB.2.11.1410010153590.4455@nanos>

On 01/10/14 01:11, Thomas Gleixner wrote:
> Bryan,
>
> On Wed, 1 Oct 2014, Bryan O'Donoghue wrote:
>
> what are you trying to achieve by sending out patches faster than
> anyone can review?

Thomas.

That's not the intention at all.

> Doing this has an obvious outcome:
>
>    1) The patches you whip up 10 seconds after the review hits your
>       inbox are likely not to be well thought out. Neither are the
>       changelogs.
>
>       Just by skimming the lot I noticed at least two issues which you
>       just mechanically fixed up without applying any thought. I'm not
>       going to tell you, simply because you are starting to abuse and
>       waste my time.
>
>    2) Keeping #1 as your modus operandi will make sure that you get on
>       the backlog list of reviewers and maintainers and in the worst
>       case on the shitlist.

1)
OK, I take your point on the frequency.

2)
On the substance.
I'm certainly not trying to antagonise you here - I assumed you were 
*suggesting* to apply those comments directly ?
Which is why I updated the sent patches with your comments - since they 
seemed more descriptive anyway - and sent back to the list.


Thanks,
Bryan

  reply	other threads:[~2014-10-01  0:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-30 23:41 [PATCH 0/2] x86: Quark: Add legacy_cache_size and TLB comments Bryan O'Donoghue
2014-09-30 23:41 ` [PATCH 1/2] x86: Quark: Update cache reporting, add Quark SoC X1000 string Bryan O'Donoghue
2014-09-30 23:41 ` [PATCH 2/2] x86: Quark: Comment setup_arch for TLB/PGE bugfix Bryan O'Donoghue
2014-10-01  6:59   ` Ong, Boon Leong
2014-10-01  0:11 ` [PATCH 0/2] x86: Quark: Add legacy_cache_size and TLB comments Thomas Gleixner
2014-10-01  0:30   ` Bryan O'Donoghue [this message]
2014-10-01  8:57     ` Thomas Gleixner
2014-10-01  9:00       ` Bryan O'Donoghue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=542B4B16.6060401@nexus-software.ie \
    --to=pure.logic@nexus-software.ie \
    --cc=davej@redhat.com \
    --cc=hmh@hmh.eng.br \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.