From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: Re: [PATCH] drm/exynos: remove ifdeferry from initialization code Date: Wed, 01 Oct 2014 14:48:49 +0900 Message-ID: <542B95C1.9070704@samsung.com> References: <1410349980-10473-1-git-send-email-a.hajda@samsung.com> <542A93FD.7020002@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <542A93FD.7020002@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andrzej Hajda Cc: Kukjin Kim , Seung-Woo Kim , open list , "open list:DRM DRIVERS FOR E..." , Kyungmin Park , "moderated list:ARM/S5P EXYNOS AR..." List-Id: linux-samsung-soc@vger.kernel.org T24gMjAxNOuFhCAwOeyblCAzMOydvCAyMDoyOSwgQW5kcnplaiBIYWpkYSB3cm90ZToKPiBIaSBJ bmtpLAo+IAo+IEdlbnRseSBwaW5nLgoKSGkgQW5kcnplaiwKCkkgbWVyZ2VkIGl0IHRvIGxvY2Fs IHJlcG9zaXRvcnkgdG8gdGVzdC4gQnV0IG5vdyBleHlub3MgZHJtIGRvZXNuJ3Qgd29yawpjb3Jy ZWN0bHkgc2luY2UgcHVsbGluZyBkcm0tbmV4dCBvZiBEYXZlIHJlZ2FyZGxlc3Mgb2YgeW91ciBw YXRjaC4KClByb2JsZW1zIGFyZSwKMS4gZXJyb3Igb2NjdXJzIHdoZW4gd2UgdHJ5IHRvIHRlc3Qg bW9kZXRlc3Qgd2l0aCAtdiBvcHRpb24gZnJvbSBzZWNvbmQKdGltZXMuCjIuIGVycm9yIG9jY3Vy cyB3aGVuIHdlIHRyeSB0byB0ZXN0IHVuYmluZC4KCk5vdyB3ZSBhcmUgY2hlY2tpbmcgdGhlc2Ug cHJvYmxlbXMuIENhbiB5b3UgdHJ5IHRvIGFsc28gY2hlY2sgaXQ/CgpUaGFua3MsCklua2kgRGFl Cgo+IAo+IEFuZHJ6ZWoKPiAKPiBPbiAwOS8xMC8yMDE0IDAxOjUzIFBNLCBBbmRyemVqIEhhamRh IHdyb3RlOgo+PiBUaGUgcGF0Y2ggcmVwbGFjZXMgc2VwYXJhdGUgY2FsbHMgdG8gZHJpdmVyIChk ZSlyZWdpc3RyYXRpb24gYnkKPj4gbG9vcHMgb3ZlciB0aGUgYXJyYXkgb2YgZHJpdmVycy4gQXMg YSByZXN1bHQgaXQgc2lnbmlmaWNhbnRseQo+PiBkZWNyZWFzZXMgbnVtYmVyIG9mIGlmZGVmcy4g QWRkaXRpb25hbGx5IGl0IG1vdmVzIGRldmljZSByZWdpc3RyYXRpb24KPj4gcmVsYXRlZCBpZmRl ZnMgdG8gaGVhZGVyIGZpbGUuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IEFuZHJ6ZWogSGFqZGEgPGEu aGFqZGFAc2Ftc3VuZy5jb20+Cj4+IC0tLQo+PiBIaSBJbmtpLAo+Pgo+PiBEdXJpbmcgdGVzdGlu ZyB5b3VyIGNvbXBvbmVudCBtYXRjaCBzdXBwb3J0IHBhdGNoIFsxXSBJIGhhdmUgcHJlcGFyZWQg cGF0Y2gKPj4gcmVtb3ZpbmcgbW9zdCBpZmRlZnMgZnJvbSBleHlub3NfZHJtX2Rydi5jLiBJdCBp cyBiYXNlZCBvbiB5b3VyIHBhdGNoLCBidXQKPj4gSSBjYW4gcmViYXNlIGl0IGlmIG5lY2Vzc2Fy eS4KPj4KPj4gWzFdOiBodHRwOi8vcGVybWFsaW5rLmdtYW5lLm9yZy9nbWFuZS5saW51eC5rZXJu ZWwuc2Ftc3VuZy1zb2MvMzcwMzEKPj4KPj4gUmVnYXJkcwo+PiBBbmRyemVqCj4+IC0tLQo+PiAg ZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2Rydi5jIHwgMTcwICsrKysrKystLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4+ICBkcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19k cm1fZHJ2LmggfCAgMjUgKysrLS0KPj4gIDIgZmlsZXMgY2hhbmdlZCwgNDggaW5zZXJ0aW9ucygr KSwgMTQ3IGRlbGV0aW9ucygtKQo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2V4 eW5vcy9leHlub3NfZHJtX2Rydi5jIGIvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJt X2Rydi5jCj4+IGluZGV4IGIyYzcxMGEuLmE2NjBlNDYgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9leHlub3MvZXh5bm9zX2RybV9kcnYuYwo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0v ZXh5bm9zL2V4eW5vc19kcm1fZHJ2LmMKPj4gQEAgLTU1Myw3NCArNTUzLDU0IEBAIHN0YXRpYyBj b25zdCBzdHJ1Y3QgY29tcG9uZW50X21hc3Rlcl9vcHMgZXh5bm9zX2RybV9vcHMgPSB7Cj4+ICAJ LnVuYmluZAkJPSBleHlub3NfZHJtX3VuYmluZCwKPj4gIH07Cj4+ICAKPj4gLXN0YXRpYyBpbnQg ZXh5bm9zX2RybV9wbGF0Zm9ybV9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ PiAtewo+PiAtCXN0cnVjdCBjb21wb25lbnRfbWF0Y2ggKm1hdGNoOwo+PiAtCWludCByZXQ7Cj4+ IC0KPj4gLQlwZGV2LT5kZXYuY29oZXJlbnRfZG1hX21hc2sgPSBETUFfQklUX01BU0soMzIpOwo+ PiAtCWV4eW5vc19kcm1fZHJpdmVyLm51bV9pb2N0bHMgPSBBUlJBWV9TSVpFKGV4eW5vc19pb2N0 bHMpOwo+PiAtCj4+ICtzdGF0aWMgc3RydWN0IHBsYXRmb3JtX2RyaXZlciAqIGNvbnN0IGV4eW5v c19kcm1fZHJpdmVyc1tdID0gewo+PiAgI2lmZGVmIENPTkZJR19EUk1fRVhZTk9TX0ZJTUQKPj4g LQlyZXQgPSBwbGF0Zm9ybV9kcml2ZXJfcmVnaXN0ZXIoJmZpbWRfZHJpdmVyKTsKPj4gLQlpZiAo cmV0IDwgMCkKPj4gLQkJcmV0dXJuIHJldDsKPj4gKwkmZmltZF9kcml2ZXIsCj4+ICAjZW5kaWYK Pj4gLQo+PiAgI2lmZGVmIENPTkZJR19EUk1fRVhZTk9TX0RQCj4+IC0JcmV0ID0gcGxhdGZvcm1f ZHJpdmVyX3JlZ2lzdGVyKCZkcF9kcml2ZXIpOwo+PiAtCWlmIChyZXQgPCAwKQo+PiAtCQlnb3Rv IGVycl91bnJlZ2lzdGVyX2ZpbWRfZHJ2Owo+PiArCSZkcF9kcml2ZXIsCj4+ICAjZW5kaWYKPj4g LQo+PiAgI2lmZGVmIENPTkZJR19EUk1fRVhZTk9TX0RTSQo+PiAtCXJldCA9IHBsYXRmb3JtX2Ry aXZlcl9yZWdpc3RlcigmZHNpX2RyaXZlcik7Cj4+IC0JaWYgKHJldCA8IDApCj4+IC0JCWdvdG8g ZXJyX3VucmVnaXN0ZXJfZHBfZHJ2Owo+PiArCSZkc2lfZHJpdmVyLAo+PiAgI2VuZGlmCj4+IC0K Pj4gICNpZmRlZiBDT05GSUdfRFJNX0VYWU5PU19IRE1JCj4+IC0JcmV0ID0gcGxhdGZvcm1fZHJp dmVyX3JlZ2lzdGVyKCZtaXhlcl9kcml2ZXIpOwo+PiAtCWlmIChyZXQgPCAwKQo+PiAtCQlnb3Rv IGVycl91bnJlZ2lzdGVyX2RzaV9kcnY7Cj4+IC0JcmV0ID0gcGxhdGZvcm1fZHJpdmVyX3JlZ2lz dGVyKCZoZG1pX2RyaXZlcik7Cj4+IC0JaWYgKHJldCA8IDApCj4+IC0JCWdvdG8gZXJyX3VucmVn aXN0ZXJfbWl4ZXJfZHJ2Owo+PiArCSZtaXhlcl9kcml2ZXIsCj4+ICsJJmhkbWlfZHJpdmVyLAo+ PiAgI2VuZGlmCj4+IC0KPj4gICNpZmRlZiBDT05GSUdfRFJNX0VYWU5PU19HMkQKPj4gLQlyZXQg PSBwbGF0Zm9ybV9kcml2ZXJfcmVnaXN0ZXIoJmcyZF9kcml2ZXIpOwo+PiAtCWlmIChyZXQgPCAw KQo+PiAtCQlnb3RvIGVycl91bnJlZ2lzdGVyX2hkbWlfZHJ2Owo+PiArCSZnMmRfZHJpdmVyLAo+ PiAgI2VuZGlmCj4+IC0KPj4gICNpZmRlZiBDT05GSUdfRFJNX0VYWU5PU19GSU1DCj4+IC0JcmV0 ID0gcGxhdGZvcm1fZHJpdmVyX3JlZ2lzdGVyKCZmaW1jX2RyaXZlcik7Cj4+IC0JaWYgKHJldCA8 IDApCj4+IC0JCWdvdG8gZXJyX3VucmVnaXN0ZXJfZzJkX2RydjsKPj4gKwkmZmltY19kcml2ZXIs Cj4+ICAjZW5kaWYKPj4gLQo+PiAgI2lmZGVmIENPTkZJR19EUk1fRVhZTk9TX1JPVEFUT1IKPj4g LQlyZXQgPSBwbGF0Zm9ybV9kcml2ZXJfcmVnaXN0ZXIoJnJvdGF0b3JfZHJpdmVyKTsKPj4gLQlp ZiAocmV0IDwgMCkKPj4gLQkJZ290byBlcnJfdW5yZWdpc3Rlcl9maW1jX2RydjsKPj4gKwkmcm90 YXRvcl9kcml2ZXIsCj4+ICAjZW5kaWYKPj4gLQo+PiAgI2lmZGVmIENPTkZJR19EUk1fRVhZTk9T X0dTQwo+PiAtCXJldCA9IHBsYXRmb3JtX2RyaXZlcl9yZWdpc3RlcigmZ3NjX2RyaXZlcik7Cj4+ IC0JaWYgKHJldCA8IDApCj4+IC0JCWdvdG8gZXJyX3VucmVnaXN0ZXJfcm90YXRvcl9kcnY7Cj4+ ICsJJmdzY19kcml2ZXIsCj4+ICAjZW5kaWYKPj4gLQo+PiAgI2lmZGVmIENPTkZJR19EUk1fRVhZ Tk9TX0lQUAo+PiAtCXJldCA9IHBsYXRmb3JtX2RyaXZlcl9yZWdpc3RlcigmaXBwX2RyaXZlcik7 Cj4+IC0JaWYgKHJldCA8IDApCj4+IC0JCWdvdG8gZXJyX3VucmVnaXN0ZXJfZ3NjX2RydjsKPj4g KwkmaXBwX2RyaXZlciwKPj4gKyNlbmRpZgo+PiArfTsKPj4gKwo+PiArc3RhdGljIGludCBleHlu b3NfZHJtX3BsYXRmb3JtX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4+ICt7 Cj4+ICsJc3RydWN0IGNvbXBvbmVudF9tYXRjaCAqbWF0Y2g7Cj4+ICsJaW50IHJldCwgaTsKPj4g Kwo+PiArCXBkZXYtPmRldi5jb2hlcmVudF9kbWFfbWFzayA9IERNQV9CSVRfTUFTSygzMik7Cj4+ ICsJZXh5bm9zX2RybV9kcml2ZXIubnVtX2lvY3RscyA9IEFSUkFZX1NJWkUoZXh5bm9zX2lvY3Rs cyk7Cj4+ICsKPj4gKwlmb3IgKGkgPSAwOyBpIDwgQVJSQVlfU0laRShleHlub3NfZHJtX2RyaXZl cnMpOyArK2kpIHsKPj4gKwkJcmV0ID0gcGxhdGZvcm1fZHJpdmVyX3JlZ2lzdGVyKGV4eW5vc19k cm1fZHJpdmVyc1tpXSk7Cj4+ICsJCWlmIChyZXQgPCAwKQo+PiArCQkJZ290byBlcnJfdW5yZWdp c3Rlcl9kcml2ZXJzOwo+PiArCX0KPj4gIAo+PiAgCXJldCA9IGV4eW5vc19wbGF0Zm9ybV9kZXZp Y2VfaXBwX3JlZ2lzdGVyKCk7Cj4+ICAJaWYgKHJldCA8IDApCj4+IC0JCWdvdG8gZXJyX3VucmVn aXN0ZXJfaXBwX2RydjsKPj4gLSNlbmRpZgo+PiArCQlnb3RvIGVycl91bnJlZ2lzdGVyX2RyaXZl cnM7Cj4+ICAKPj4gIAltYXRjaCA9IGV4eW5vc19kcm1fbWF0Y2hfYWRkKCZwZGV2LT5kZXYpOwo+ PiAgCWlmIChJU19FUlIobWF0Y2gpKSB7Cj4+IEBAIC02MzIsOTYgKzYxMiwyNCBAQCBzdGF0aWMg aW50IGV4eW5vc19kcm1fcGxhdGZvcm1fcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRl dikKPj4gIAkJCQkJCW1hdGNoKTsKPj4gIAo+PiAgZXJyX3VucmVnaXN0ZXJfaXBwX2RldjoKPj4g LQo+PiAtI2lmZGVmIENPTkZJR19EUk1fRVhZTk9TX0lQUAo+PiAgCWV4eW5vc19wbGF0Zm9ybV9k ZXZpY2VfaXBwX3VucmVnaXN0ZXIoKTsKPj4gLWVycl91bnJlZ2lzdGVyX2lwcF9kcnY6Cj4+IC0J cGxhdGZvcm1fZHJpdmVyX3VucmVnaXN0ZXIoJmlwcF9kcml2ZXIpOwo+PiAtZXJyX3VucmVnaXN0 ZXJfZ3NjX2RydjoKPj4gLSNlbmRpZgo+PiAgCj4+IC0jaWZkZWYgQ09ORklHX0RSTV9FWFlOT1Nf R1NDCj4+IC0JcGxhdGZvcm1fZHJpdmVyX3VucmVnaXN0ZXIoJmdzY19kcml2ZXIpOwo+PiAtZXJy X3VucmVnaXN0ZXJfcm90YXRvcl9kcnY6Cj4+IC0jZW5kaWYKPj4gK2Vycl91bnJlZ2lzdGVyX2Ry aXZlcnM6Cj4+ICsJd2hpbGUgKC0taSA+PSAwKQo+PiArCQlwbGF0Zm9ybV9kcml2ZXJfdW5yZWdp c3RlcihleHlub3NfZHJtX2RyaXZlcnNbaV0pOwo+PiAgCj4+IC0jaWZkZWYgQ09ORklHX0RSTV9F WFlOT1NfUk9UQVRPUgo+PiAtCXBsYXRmb3JtX2RyaXZlcl91bnJlZ2lzdGVyKCZyb3RhdG9yX2Ry aXZlcik7Cj4+IC1lcnJfdW5yZWdpc3Rlcl9maW1jX2RydjoKPj4gLSNlbmRpZgo+PiAtCj4+IC0j aWZkZWYgQ09ORklHX0RSTV9FWFlOT1NfRklNQwo+PiAtCXBsYXRmb3JtX2RyaXZlcl91bnJlZ2lz dGVyKCZmaW1jX2RyaXZlcik7Cj4+IC1lcnJfdW5yZWdpc3Rlcl9nMmRfZHJ2Ogo+PiAtI2VuZGlm Cj4+IC0KPj4gLSNpZmRlZiBDT05GSUdfRFJNX0VYWU5PU19HMkQKPj4gLQlwbGF0Zm9ybV9kcml2 ZXJfdW5yZWdpc3RlcigmZzJkX2RyaXZlcik7Cj4+IC1lcnJfdW5yZWdpc3Rlcl9oZG1pX2RydjoK Pj4gLSNlbmRpZgo+PiAtCj4+IC0jaWZkZWYgQ09ORklHX0RSTV9FWFlOT1NfSERNSQo+PiAtCXBs YXRmb3JtX2RyaXZlcl91bnJlZ2lzdGVyKCZoZG1pX2RyaXZlcik7Cj4+IC1lcnJfdW5yZWdpc3Rl cl9taXhlcl9kcnY6Cj4+IC0JcGxhdGZvcm1fZHJpdmVyX3VucmVnaXN0ZXIoJm1peGVyX2RyaXZl cik7Cj4+IC1lcnJfdW5yZWdpc3Rlcl9kc2lfZHJ2Ogo+PiAtI2VuZGlmCj4+IC0KPj4gLSNpZmRl ZiBDT05GSUdfRFJNX0VYWU5PU19EU0kKPj4gLQlwbGF0Zm9ybV9kcml2ZXJfdW5yZWdpc3Rlcigm ZHNpX2RyaXZlcik7Cj4+IC1lcnJfdW5yZWdpc3Rlcl9kcF9kcnY6Cj4+IC0jZW5kaWYKPj4gLQo+ PiAtI2lmZGVmIENPTkZJR19EUk1fRVhZTk9TX0RQCj4+IC0JcGxhdGZvcm1fZHJpdmVyX3VucmVn aXN0ZXIoJmRwX2RyaXZlcik7Cj4+IC1lcnJfdW5yZWdpc3Rlcl9maW1kX2RydjoKPj4gLSNlbmRp Zgo+PiAtCj4+IC0jaWZkZWYgQ09ORklHX0RSTV9FWFlOT1NfRklNRAo+PiAtCXBsYXRmb3JtX2Ry aXZlcl91bnJlZ2lzdGVyKCZmaW1kX2RyaXZlcik7Cj4+IC0jZW5kaWYKPj4gIAlyZXR1cm4gcmV0 Owo+PiAgfQo+PiAgCj4+ICBzdGF0aWMgaW50IGV4eW5vc19kcm1fcGxhdGZvcm1fcmVtb3ZlKHN0 cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4+ICB7Cj4+IC0jaWZkZWYgQ09ORklHX0RSTV9F WFlOT1NfSVBQCj4+IC0JZXh5bm9zX3BsYXRmb3JtX2RldmljZV9pcHBfdW5yZWdpc3RlcigpOwo+ PiAtCXBsYXRmb3JtX2RyaXZlcl91bnJlZ2lzdGVyKCZpcHBfZHJpdmVyKTsKPj4gLSNlbmRpZgo+ PiAtCj4+IC0jaWZkZWYgQ09ORklHX0RSTV9FWFlOT1NfR1NDCj4+IC0JcGxhdGZvcm1fZHJpdmVy X3VucmVnaXN0ZXIoJmdzY19kcml2ZXIpOwo+PiAtI2VuZGlmCj4+IC0KPj4gLSNpZmRlZiBDT05G SUdfRFJNX0VYWU5PU19ST1RBVE9SCj4+IC0JcGxhdGZvcm1fZHJpdmVyX3VucmVnaXN0ZXIoJnJv dGF0b3JfZHJpdmVyKTsKPj4gLSNlbmRpZgo+PiAtCj4+IC0jaWZkZWYgQ09ORklHX0RSTV9FWFlO T1NfRklNQwo+PiAtCXBsYXRmb3JtX2RyaXZlcl91bnJlZ2lzdGVyKCZmaW1jX2RyaXZlcik7Cj4+ IC0jZW5kaWYKPj4gLQo+PiAtI2lmZGVmIENPTkZJR19EUk1fRVhZTk9TX0cyRAo+PiAtCXBsYXRm b3JtX2RyaXZlcl91bnJlZ2lzdGVyKCZnMmRfZHJpdmVyKTsKPj4gLSNlbmRpZgo+PiAtCj4+IC0j aWZkZWYgQ09ORklHX0RSTV9FWFlOT1NfSERNSQo+PiAtCXBsYXRmb3JtX2RyaXZlcl91bnJlZ2lz dGVyKCZtaXhlcl9kcml2ZXIpOwo+PiAtCXBsYXRmb3JtX2RyaXZlcl91bnJlZ2lzdGVyKCZoZG1p X2RyaXZlcik7Cj4+IC0jZW5kaWYKPj4gKwlpbnQgaTsKPj4gIAo+PiAtI2lmZGVmIENPTkZJR19E Uk1fRVhZTk9TX0ZJTUQKPj4gLQlwbGF0Zm9ybV9kcml2ZXJfdW5yZWdpc3RlcigmZmltZF9kcml2 ZXIpOwo+PiAtI2VuZGlmCj4+ICsJZXh5bm9zX3BsYXRmb3JtX2RldmljZV9pcHBfdW5yZWdpc3Rl cigpOwo+PiAgCj4+IC0jaWZkZWYgQ09ORklHX0RSTV9FWFlOT1NfRFNJCj4+IC0JcGxhdGZvcm1f ZHJpdmVyX3VucmVnaXN0ZXIoJmRzaV9kcml2ZXIpOwo+PiAtI2VuZGlmCj4+ICsJZm9yIChpID0g QVJSQVlfU0laRShleHlub3NfZHJtX2RyaXZlcnMpIC0gMTsgaSA+PSAwOyAtLWkpCj4+ICsJCXBs YXRmb3JtX2RyaXZlcl91bnJlZ2lzdGVyKGV4eW5vc19kcm1fZHJpdmVyc1tpXSk7Cj4+ICAKPj4g LSNpZmRlZiBDT05GSUdfRFJNX0VYWU5PU19EUAo+PiAtCXBsYXRmb3JtX2RyaXZlcl91bnJlZ2lz dGVyKCZkcF9kcml2ZXIpOwo+PiAtI2VuZGlmCj4+ICAJY29tcG9uZW50X21hc3Rlcl9kZWwoJnBk ZXYtPmRldiwgJmV4eW5vc19kcm1fb3BzKTsKPj4gIAlyZXR1cm4gMDsKPj4gIH0KPj4gQEAgLTc0 NSwxMSArNjUzLDkgQEAgc3RhdGljIGludCBleHlub3NfZHJtX2luaXQodm9pZCkKPj4gIAlpZiAo SVNfRVJSKGV4eW5vc19kcm1fcGRldikpCj4+ICAJCXJldHVybiBQVFJfRVJSKGV4eW5vc19kcm1f cGRldik7Cj4+ICAKPj4gLSNpZmRlZiBDT05GSUdfRFJNX0VYWU5PU19WSURJCj4+ICAJcmV0ID0g ZXh5bm9zX2RybV9wcm9iZV92aWRpKCk7Cj4+ICAJaWYgKHJldCA8IDApCj4+ICAJCWdvdG8gZXJy X3VucmVnaXN0ZXJfcGQ7Cj4+IC0jZW5kaWYKPj4gIAo+PiAgCXJldCA9IHBsYXRmb3JtX2RyaXZl cl9yZWdpc3RlcigmZXh5bm9zX2RybV9wbGF0Zm9ybV9kcml2ZXIpOwo+PiAgCWlmIChyZXQpCj4+ IEBAIC03NTgsMTEgKzY2NCw5IEBAIHN0YXRpYyBpbnQgZXh5bm9zX2RybV9pbml0KHZvaWQpCj4+ ICAJcmV0dXJuIDA7Cj4+ICAKPj4gIGVycl9yZW1vdmVfdmlkaToKPj4gLSNpZmRlZiBDT05GSUdf RFJNX0VYWU5PU19WSURJCj4+ICAJZXh5bm9zX2RybV9yZW1vdmVfdmlkaSgpOwo+PiAgCj4+ICBl cnJfdW5yZWdpc3Rlcl9wZDoKPj4gLSNlbmRpZgo+PiAgCXBsYXRmb3JtX2RldmljZV91bnJlZ2lz dGVyKGV4eW5vc19kcm1fcGRldik7Cj4+ICAKPj4gIAlyZXR1cm4gcmV0Owo+PiBAQCAtNzcxLDkg KzY3NSw5IEBAIGVycl91bnJlZ2lzdGVyX3BkOgo+PiAgc3RhdGljIHZvaWQgZXh5bm9zX2RybV9l eGl0KHZvaWQpCj4+ICB7Cj4+ICAJcGxhdGZvcm1fZHJpdmVyX3VucmVnaXN0ZXIoJmV4eW5vc19k cm1fcGxhdGZvcm1fZHJpdmVyKTsKPj4gLSNpZmRlZiBDT05GSUdfRFJNX0VYWU5PU19WSURJCj4+ ICsKPj4gIAlleHlub3NfZHJtX3JlbW92ZV92aWRpKCk7Cj4+IC0jZW5kaWYKPj4gKwo+PiAgCXBs YXRmb3JtX2RldmljZV91bnJlZ2lzdGVyKGV4eW5vc19kcm1fcGRldik7Cj4+ICB9Cj4+ICAKPj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RybV9kcnYuaCBiL2Ry aXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RybV9kcnYuaAo+PiBpbmRleCA2OWE2ZmEzLi43 NmQ1ZDAyIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1f ZHJ2LmgKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2Rydi5oCj4+ IEBAIC0zMjQsMTUgKzMyNCwxNCBAQCBpbnQgZXh5bm9zX3BsYXRmb3JtX2RldmljZV9oZG1pX3Jl Z2lzdGVyKHZvaWQpOwo+PiAgICovCj4+ICB2b2lkIGV4eW5vc19wbGF0Zm9ybV9kZXZpY2VfaGRt aV91bnJlZ2lzdGVyKHZvaWQpOwo+PiAgCj4+IC0vKgo+PiAtICogdGhpcyBmdW5jdGlvbiByZWdp c3RlcnMgZXh5bm9zIGRybSBpcHAgcGxhdGZvcm0gZGV2aWNlLgo+PiAtICovCj4+ICsjaWZkZWYg Q09ORklHX0RSTV9FWFlOT1NfSVBQCj4+ICBpbnQgZXh5bm9zX3BsYXRmb3JtX2RldmljZV9pcHBf cmVnaXN0ZXIodm9pZCk7Cj4+IC0KPj4gLS8qCj4+IC0gKiB0aGlzIGZ1bmN0aW9uIHVucmVnaXN0 ZXJzIGV4eW5vcyBkcm0gaXBwIHBsYXRmb3JtIGRldmljZSBpZiBpdCBleGlzdHMuCj4+IC0gKi8K Pj4gIHZvaWQgZXh5bm9zX3BsYXRmb3JtX2RldmljZV9pcHBfdW5yZWdpc3Rlcih2b2lkKTsKPj4g KyNlbHNlCj4+ICtzdGF0aWMgaW5saW5lIGludCBleHlub3NfcGxhdGZvcm1fZGV2aWNlX2lwcF9y ZWdpc3Rlcih2b2lkKSB7IHJldHVybiAwOyB9Cj4+ICtzdGF0aWMgaW5saW5lIHZvaWQgZXh5bm9z X3BsYXRmb3JtX2RldmljZV9pcHBfdW5yZWdpc3Rlcih2b2lkKSB7fQo+PiArI2VuZGlmCj4+ICsK Pj4gIAo+PiAgI2lmZGVmIENPTkZJR19EUk1fRVhZTk9TX0RQSQo+PiAgc3RydWN0IGV4eW5vc19k cm1fZGlzcGxheSAqIGV4eW5vc19kcGlfcHJvYmUoc3RydWN0IGRldmljZSAqZGV2KTsKPj4gQEAg LTM0MywxNSArMzQyLDEzIEBAIGV4eW5vc19kcGlfcHJvYmUoc3RydWN0IGRldmljZSAqZGV2KSB7 IHJldHVybiBOVUxMOyB9Cj4+ICBzdGF0aWMgaW5saW5lIGludCBleHlub3NfZHBpX3JlbW92ZShz dHJ1Y3QgZGV2aWNlICpkZXYpIHsgcmV0dXJuIDA7IH0KPj4gICNlbmRpZgo+PiAgCj4+IC0vKgo+ PiAtICogdGhpcyBmdW5jdGlvbiByZWdpc3RlcnMgZXh5bm9zIGRybSB2aWRpIHBsYXRmb3JtIGRl dmljZS9kcml2ZXIuCj4+IC0gKi8KPj4gKyNpZmRlZiBDT05GSUdfRFJNX0VYWU5PU19WSURJCj4+ ICBpbnQgZXh5bm9zX2RybV9wcm9iZV92aWRpKHZvaWQpOwo+PiAtCj4+IC0vKgo+PiAtICogdGhp cyBmdW5jdGlvbiB1bnJlZ2lzdGVyIGV4eW5vcyBkcm0gdmlkaSBwbGF0Zm9ybSBkZXZpY2UvZHJp dmVyLgo+PiAtICovCj4+ICB2b2lkIGV4eW5vc19kcm1fcmVtb3ZlX3ZpZGkodm9pZCk7Cj4+ICsj ZWxzZQo+PiArc3RhdGljIGlubGluZSBpbnQgZXh5bm9zX2RybV9wcm9iZV92aWRpKHZvaWQpIHsg cmV0dXJuIDA7IH0KPj4gK3N0YXRpYyBpbmxpbmUgdm9pZCBleHlub3NfZHJtX3JlbW92ZV92aWRp KHZvaWQpIHt9Cj4+ICsjZW5kaWYKPj4gIAo+PiAgLyogVGhpcyBmdW5jdGlvbiBjcmVhdGVzIGEg ZW5jb2RlciBhbmQgYSBjb25uZWN0b3IsIGFuZCBpbml0aWFsaXplcyB0aGVtLiAqLwo+PiAgaW50 IGV4eW5vc19kcm1fY3JlYXRlX2VuY19jb25uKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gCj4g LS0KPiBUbyB1bnN1YnNjcmliZSBmcm9tIHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJz Y3JpYmUgbGludXgtc2Ftc3VuZy1zb2MiIGluCj4gdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1h am9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKPiBNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8v dmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwKPiAKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751246AbaJAFtD (ORCPT ); Wed, 1 Oct 2014 01:49:03 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:56125 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750944AbaJAFtA (ORCPT ); Wed, 1 Oct 2014 01:49:00 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee690-f79ab6d0000046f7-7d-542b95c16fd1 Content-transfer-encoding: 8BIT Message-id: <542B95C1.9070704@samsung.com> Date: Wed, 01 Oct 2014 14:48:49 +0900 From: Inki Dae User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 To: Andrzej Hajda Cc: Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , David Airlie , Kukjin Kim , "open list:DRM DRIVERS FOR E..." , "moderated list:ARM/S5P EXYNOS AR..." , open list Subject: Re: [PATCH] drm/exynos: remove ifdeferry from initialization code References: <1410349980-10473-1-git-send-email-a.hajda@samsung.com> <542A93FD.7020002@samsung.com> In-reply-to: <542A93FD.7020002@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBIsWRmVeSWpSXmKPExsWyRsSkRPfgVO0Qgyc7bCxurTvHatF77iST xZWv79ksXty7yGLRu+Aqm8XZpjfsFpd3zWGzmHF+H5PFjMkv2Rw4PbZ/e8Dqcb/7OJNH35ZV jB6fN8kFsERx2aSk5mSWpRbp2yVwZTxe/oet4FdAxbe+dywNjAucuxg5OSQETCQebl/MCGGL SVy4t56ti5GLQ0hgKaPE0nVfWWGKdp+9BZVYxChx+uULFpAEr4CgxI/J94BsDg5mAXmJI5ey QcLMAuoSk+YtYoaof8Uo8e3eJUaIei2JhxcawIayCKhKXLt3mB3EZgOyJ664zwZiiwqESbx4 tYsZxBYBGjT75B2wQcwCncwSc+c8ABskLOAlcfb2f7BmIYEUicl9T8FsTgFtiZnbv4JdKiFw iV3idP85FohtAhLfJh8Cu1RCQFZi0wFmiM8kJQ6uuMEygVFsFpJ/ZiH8MwvJPwsYmVcxiqYW JBcUJ6UXmegVJ+YWl+al6yXn525iBEbg6X/PJuxgvHfA+hCjAAejEg+vQoJ2iBBrYllxZe4h RlOgIyYyS4km5wPjPK8k3tDYzMjC1MTU2Mjc0kxJnPe11M9gIYH0xJLU7NTUgtSi+KLSnNTi Q4xMHJxSDYwSKw923l/sdqLEJvPm/INhZZtfHDVa27HgzRvGyl2BbreTpMNez3s5d5/EqlNC +fyaogmbOeSUq96x72tY9MywO+7eO+mV/r98psYYVq92Wfnc60e+i0i4T+By+biiKzNcGCba 2oW42fR/i7p7Pc7Z0b7r1o/HW6+H/m2rNZr84vmqvCnqVe5KLMUZiYZazEXFiQDW0JR/uwIA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrEIsWRmVeSWpSXmKPExsVy+t9jAd2DU7VDDL69MrS4te4cq0XvuZNM Fle+vmezeHHvIotF74KrbBZnm96wW1zeNYfNYsb5fUwWMya/ZHPg9Nj+7QGrx/3u40wefVtW MXp83iQXwBLVwGiTkZqYklqkkJqXnJ+SmZduq+QdHO8cb2pmYKhraGlhrqSQl5ibaqvk4hOg 65aZA3SMkkJZYk4pUCggsbhYSd8O04TQEDddC5jGCF3fkCC4HiMDNJCwhjHj8fI/bAW/Aiq+ 9b1jaWBc4NzFyMkhIWAisfvsLTYIW0ziwr31QDYXh5DAIkaJ0y9fsIAkeAUEJX5Mvgdkc3Aw C8hLHLmUDRJmFlCXmDRvETNE/StGiW/3LjFC1GtJPLzQwApiswioSly7d5gdxGYDsieuuA+2 TFQgTOLFq13MILYI0KDZJ++ADWIW6GSWmDvnAdggYQEvibO3/4M1CwmkSEzuewpmcwpoS8zc /pVtAqPALCT3zUK4bxaS+xYwMq9iFE0tSC4oTkrPNdIrTswtLs1L10vOz93ECI7vZ9I7GFc1 WBxiFOBgVOLhrUjSDhFiTSwrrsw9xCjBwawkwjuxAijEm5JYWZValB9fVJqTWnyI0RTou4nM UqLJ+cDUk1cSb2hsYmZkaWRuaGFkbK4kznuw1TpQSCA9sSQ1OzW1ILUIpo+Jg1OqgdHusIi+ Yq3GPGvOnTx9qxmTtUWe7rwZsCK2tk4gzHKi0aTdlo6WH6IynzO8fGvS8vGs4z8/I8bqiVnX Y4JOfYyLeDNRP3HmE7E35xtEW6dEbGytyerbtnznw3NLAg8801G0idR1+DeXecKqLXufhMnc 8N4oHFIynSNSe29UW6n+zgctea5MpUosxRmJhlrMRcWJAHftqCYFAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014년 09월 30일 20:29, Andrzej Hajda wrote: > Hi Inki, > > Gently ping. Hi Andrzej, I merged it to local repository to test. But now exynos drm doesn't work correctly since pulling drm-next of Dave regardless of your patch. Problems are, 1. error occurs when we try to test modetest with -v option from second times. 2. error occurs when we try to test unbind. Now we are checking these problems. Can you try to also check it? Thanks, Inki Dae > > Andrzej > > On 09/10/2014 01:53 PM, Andrzej Hajda wrote: >> The patch replaces separate calls to driver (de)registration by >> loops over the array of drivers. As a result it significantly >> decreases number of ifdefs. Additionally it moves device registration >> related ifdefs to header file. >> >> Signed-off-by: Andrzej Hajda >> --- >> Hi Inki, >> >> During testing your component match support patch [1] I have prepared patch >> removing most ifdefs from exynos_drm_drv.c. It is based on your patch, but >> I can rebase it if necessary. >> >> [1]: http://permalink.gmane.org/gmane.linux.kernel.samsung-soc/37031 >> >> Regards >> Andrzej >> --- >> drivers/gpu/drm/exynos/exynos_drm_drv.c | 170 +++++++------------------------- >> drivers/gpu/drm/exynos/exynos_drm_drv.h | 25 +++-- >> 2 files changed, 48 insertions(+), 147 deletions(-) >> >> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c >> index b2c710a..a660e46 100644 >> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c >> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c >> @@ -553,74 +553,54 @@ static const struct component_master_ops exynos_drm_ops = { >> .unbind = exynos_drm_unbind, >> }; >> >> -static int exynos_drm_platform_probe(struct platform_device *pdev) >> -{ >> - struct component_match *match; >> - int ret; >> - >> - pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32); >> - exynos_drm_driver.num_ioctls = ARRAY_SIZE(exynos_ioctls); >> - >> +static struct platform_driver * const exynos_drm_drivers[] = { >> #ifdef CONFIG_DRM_EXYNOS_FIMD >> - ret = platform_driver_register(&fimd_driver); >> - if (ret < 0) >> - return ret; >> + &fimd_driver, >> #endif >> - >> #ifdef CONFIG_DRM_EXYNOS_DP >> - ret = platform_driver_register(&dp_driver); >> - if (ret < 0) >> - goto err_unregister_fimd_drv; >> + &dp_driver, >> #endif >> - >> #ifdef CONFIG_DRM_EXYNOS_DSI >> - ret = platform_driver_register(&dsi_driver); >> - if (ret < 0) >> - goto err_unregister_dp_drv; >> + &dsi_driver, >> #endif >> - >> #ifdef CONFIG_DRM_EXYNOS_HDMI >> - ret = platform_driver_register(&mixer_driver); >> - if (ret < 0) >> - goto err_unregister_dsi_drv; >> - ret = platform_driver_register(&hdmi_driver); >> - if (ret < 0) >> - goto err_unregister_mixer_drv; >> + &mixer_driver, >> + &hdmi_driver, >> #endif >> - >> #ifdef CONFIG_DRM_EXYNOS_G2D >> - ret = platform_driver_register(&g2d_driver); >> - if (ret < 0) >> - goto err_unregister_hdmi_drv; >> + &g2d_driver, >> #endif >> - >> #ifdef CONFIG_DRM_EXYNOS_FIMC >> - ret = platform_driver_register(&fimc_driver); >> - if (ret < 0) >> - goto err_unregister_g2d_drv; >> + &fimc_driver, >> #endif >> - >> #ifdef CONFIG_DRM_EXYNOS_ROTATOR >> - ret = platform_driver_register(&rotator_driver); >> - if (ret < 0) >> - goto err_unregister_fimc_drv; >> + &rotator_driver, >> #endif >> - >> #ifdef CONFIG_DRM_EXYNOS_GSC >> - ret = platform_driver_register(&gsc_driver); >> - if (ret < 0) >> - goto err_unregister_rotator_drv; >> + &gsc_driver, >> #endif >> - >> #ifdef CONFIG_DRM_EXYNOS_IPP >> - ret = platform_driver_register(&ipp_driver); >> - if (ret < 0) >> - goto err_unregister_gsc_drv; >> + &ipp_driver, >> +#endif >> +}; >> + >> +static int exynos_drm_platform_probe(struct platform_device *pdev) >> +{ >> + struct component_match *match; >> + int ret, i; >> + >> + pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32); >> + exynos_drm_driver.num_ioctls = ARRAY_SIZE(exynos_ioctls); >> + >> + for (i = 0; i < ARRAY_SIZE(exynos_drm_drivers); ++i) { >> + ret = platform_driver_register(exynos_drm_drivers[i]); >> + if (ret < 0) >> + goto err_unregister_drivers; >> + } >> >> ret = exynos_platform_device_ipp_register(); >> if (ret < 0) >> - goto err_unregister_ipp_drv; >> -#endif >> + goto err_unregister_drivers; >> >> match = exynos_drm_match_add(&pdev->dev); >> if (IS_ERR(match)) { >> @@ -632,96 +612,24 @@ static int exynos_drm_platform_probe(struct platform_device *pdev) >> match); >> >> err_unregister_ipp_dev: >> - >> -#ifdef CONFIG_DRM_EXYNOS_IPP >> exynos_platform_device_ipp_unregister(); >> -err_unregister_ipp_drv: >> - platform_driver_unregister(&ipp_driver); >> -err_unregister_gsc_drv: >> -#endif >> >> -#ifdef CONFIG_DRM_EXYNOS_GSC >> - platform_driver_unregister(&gsc_driver); >> -err_unregister_rotator_drv: >> -#endif >> +err_unregister_drivers: >> + while (--i >= 0) >> + platform_driver_unregister(exynos_drm_drivers[i]); >> >> -#ifdef CONFIG_DRM_EXYNOS_ROTATOR >> - platform_driver_unregister(&rotator_driver); >> -err_unregister_fimc_drv: >> -#endif >> - >> -#ifdef CONFIG_DRM_EXYNOS_FIMC >> - platform_driver_unregister(&fimc_driver); >> -err_unregister_g2d_drv: >> -#endif >> - >> -#ifdef CONFIG_DRM_EXYNOS_G2D >> - platform_driver_unregister(&g2d_driver); >> -err_unregister_hdmi_drv: >> -#endif >> - >> -#ifdef CONFIG_DRM_EXYNOS_HDMI >> - platform_driver_unregister(&hdmi_driver); >> -err_unregister_mixer_drv: >> - platform_driver_unregister(&mixer_driver); >> -err_unregister_dsi_drv: >> -#endif >> - >> -#ifdef CONFIG_DRM_EXYNOS_DSI >> - platform_driver_unregister(&dsi_driver); >> -err_unregister_dp_drv: >> -#endif >> - >> -#ifdef CONFIG_DRM_EXYNOS_DP >> - platform_driver_unregister(&dp_driver); >> -err_unregister_fimd_drv: >> -#endif >> - >> -#ifdef CONFIG_DRM_EXYNOS_FIMD >> - platform_driver_unregister(&fimd_driver); >> -#endif >> return ret; >> } >> >> static int exynos_drm_platform_remove(struct platform_device *pdev) >> { >> -#ifdef CONFIG_DRM_EXYNOS_IPP >> - exynos_platform_device_ipp_unregister(); >> - platform_driver_unregister(&ipp_driver); >> -#endif >> - >> -#ifdef CONFIG_DRM_EXYNOS_GSC >> - platform_driver_unregister(&gsc_driver); >> -#endif >> - >> -#ifdef CONFIG_DRM_EXYNOS_ROTATOR >> - platform_driver_unregister(&rotator_driver); >> -#endif >> - >> -#ifdef CONFIG_DRM_EXYNOS_FIMC >> - platform_driver_unregister(&fimc_driver); >> -#endif >> - >> -#ifdef CONFIG_DRM_EXYNOS_G2D >> - platform_driver_unregister(&g2d_driver); >> -#endif >> - >> -#ifdef CONFIG_DRM_EXYNOS_HDMI >> - platform_driver_unregister(&mixer_driver); >> - platform_driver_unregister(&hdmi_driver); >> -#endif >> + int i; >> >> -#ifdef CONFIG_DRM_EXYNOS_FIMD >> - platform_driver_unregister(&fimd_driver); >> -#endif >> + exynos_platform_device_ipp_unregister(); >> >> -#ifdef CONFIG_DRM_EXYNOS_DSI >> - platform_driver_unregister(&dsi_driver); >> -#endif >> + for (i = ARRAY_SIZE(exynos_drm_drivers) - 1; i >= 0; --i) >> + platform_driver_unregister(exynos_drm_drivers[i]); >> >> -#ifdef CONFIG_DRM_EXYNOS_DP >> - platform_driver_unregister(&dp_driver); >> -#endif >> component_master_del(&pdev->dev, &exynos_drm_ops); >> return 0; >> } >> @@ -745,11 +653,9 @@ static int exynos_drm_init(void) >> if (IS_ERR(exynos_drm_pdev)) >> return PTR_ERR(exynos_drm_pdev); >> >> -#ifdef CONFIG_DRM_EXYNOS_VIDI >> ret = exynos_drm_probe_vidi(); >> if (ret < 0) >> goto err_unregister_pd; >> -#endif >> >> ret = platform_driver_register(&exynos_drm_platform_driver); >> if (ret) >> @@ -758,11 +664,9 @@ static int exynos_drm_init(void) >> return 0; >> >> err_remove_vidi: >> -#ifdef CONFIG_DRM_EXYNOS_VIDI >> exynos_drm_remove_vidi(); >> >> err_unregister_pd: >> -#endif >> platform_device_unregister(exynos_drm_pdev); >> >> return ret; >> @@ -771,9 +675,9 @@ err_unregister_pd: >> static void exynos_drm_exit(void) >> { >> platform_driver_unregister(&exynos_drm_platform_driver); >> -#ifdef CONFIG_DRM_EXYNOS_VIDI >> + >> exynos_drm_remove_vidi(); >> -#endif >> + >> platform_device_unregister(exynos_drm_pdev); >> } >> >> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h b/drivers/gpu/drm/exynos/exynos_drm_drv.h >> index 69a6fa3..76d5d02 100644 >> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.h >> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h >> @@ -324,15 +324,14 @@ int exynos_platform_device_hdmi_register(void); >> */ >> void exynos_platform_device_hdmi_unregister(void); >> >> -/* >> - * this function registers exynos drm ipp platform device. >> - */ >> +#ifdef CONFIG_DRM_EXYNOS_IPP >> int exynos_platform_device_ipp_register(void); >> - >> -/* >> - * this function unregisters exynos drm ipp platform device if it exists. >> - */ >> void exynos_platform_device_ipp_unregister(void); >> +#else >> +static inline int exynos_platform_device_ipp_register(void) { return 0; } >> +static inline void exynos_platform_device_ipp_unregister(void) {} >> +#endif >> + >> >> #ifdef CONFIG_DRM_EXYNOS_DPI >> struct exynos_drm_display * exynos_dpi_probe(struct device *dev); >> @@ -343,15 +342,13 @@ exynos_dpi_probe(struct device *dev) { return NULL; } >> static inline int exynos_dpi_remove(struct device *dev) { return 0; } >> #endif >> >> -/* >> - * this function registers exynos drm vidi platform device/driver. >> - */ >> +#ifdef CONFIG_DRM_EXYNOS_VIDI >> int exynos_drm_probe_vidi(void); >> - >> -/* >> - * this function unregister exynos drm vidi platform device/driver. >> - */ >> void exynos_drm_remove_vidi(void); >> +#else >> +static inline int exynos_drm_probe_vidi(void) { return 0; } >> +static inline void exynos_drm_remove_vidi(void) {} >> +#endif >> >> /* This function creates a encoder and a connector, and initializes them. */ >> int exynos_drm_create_enc_conn(struct drm_device *dev, > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >