From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH v2 6/8] drm/radeon: cope with foreign fences inside the reservation object Date: Wed, 01 Oct 2014 11:22:43 +0200 Message-ID: <542BC7E3.3050805@canonical.com> References: <1410957305-10190-1-git-send-email-maarten.lankhorst@canonical.com> <1410957305-10190-7-git-send-email-maarten.lankhorst@canonical.com> <54198803.2040508@vodafone.de> <5423F0EA.4030708@canonical.com> <542BC209.4040906@canonical.com> <542BC39D.2030908@vodafone.de> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by gabe.freedesktop.org (Postfix) with ESMTP id 185316E185 for ; Wed, 1 Oct 2014 02:22:46 -0700 (PDT) In-Reply-To: <542BC39D.2030908@vodafone.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?windows-1252?Q?Christian_K=F6nig?= , dri-devel@lists.freedesktop.org Cc: "Deucher, Alexander" , =?windows-1252?Q?Michel_D=E4nzer?= List-Id: dri-devel@lists.freedesktop.org Hey, Op 01-10-14 om 11:04 schreef Christian K=F6nig: > Am 01.10.2014 um 10:57 schrieb Maarten Lankhorst: >> Op 25-09-14 om 12:39 schreef Maarten Lankhorst: >>> Not the whole world is a radeon! :-) >>> Signed-off-by: Maarten Lankhorst >>> --- >>> Changes: >>> - Removed interruptible parameter, only 1 place has a use for it, >>> and it's the only place that can hit it. >>> - Fail faster in radeon_semaphore_sync_resv. >>> - Make the break on error in radeon_cs.c more explicit. >>> - Upgrade the unlikely() to a WARN_ON_ONCE() in radeon_fence_wait, with= a comment explaining why. >> Ping, can you review? > > LGTM, patch is Reviewed-by: Christian K=F6nig > > But we might want to pull it in through Alex drm-next-3.18 (or -3.19) bra= nch to avoid merge conflicts. I can push nouveau through my own tree and once the patches are merged get = the radeon changes through agd5f's tree? ~Maarten