Re: [PATCH v5] can: flexcan: Re-write receive path to use MB queue instead of FIFO

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1196 bytes --]

On 10/01/2014 11:34 AM, David Jander wrote:
[...]

> Back to topic: Can one of the maintainers (Wolfgang, Marc) give an opinion on
> how to best solve the following two issues:
> 
> 1.- Using MB area instead of FIFO for flexcan breaks RTR reception on older
> SoC's. My proposal is to modify my approach as to have two different IRQ
> handling paths: One that off-loads the RX-FIFO into the cyclic-buffer for
> older chips and one that uses the whole MB area and off-loads it into the same
> cyclic buffer for i.MX6, Vybrid and newer chips.

Sounds good.

> 2.- Since the problem addressed by my patch to at91_can is very similar, what
> about solving these problems in the SocketCAN framework (if that is possible)?

Have you had a look at my rx-fifo branch in
https://gitorious.org/linux-can/linux-can-next? It already tries to
abstract the simulation of the FIFO with the linear mailboxes.

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]