From: Michal Marek <mmarek@suse.cz>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: Randy Dunlap <rdunlap@infradead.org>,
Christoph Hellwig <hch@infradead.org>,
Joe Perches <joe@perches.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] limit _shipped to c,h and S files
Date: Wed, 01 Oct 2014 15:55:11 +0200 [thread overview]
Message-ID: <542C07BF.6030703@suse.cz> (raw)
In-Reply-To: <20141001133659.GC5560@opentech.at>
On 2014-10-01 15:36, Nicholas Mc Guire wrote:
>
> limit _shipped to c,h and S files
>
> _shipped targets are intended for generated source files which should
> not permit .o binary blobs which is currently the case. This patch
> simply restricts _shipped targets to .c, .h and .S files.
Patches 1/3 and 3/3 are fine, but I'm not convinced about this one.
Sure, binary blobs are often distributed as *.o_shipped, but they are
not going away if you remove support for _shipped.
> Note that this patch breaks the handline of drivers/net/wan/wanxlfw.inc_shipped
> which probably really should be moved to a loadable firmware and use
> request_firmware - a short term fix could be to move it to a .h file.
At a minimum, the patch series should address this before limiting
support for *_shipped.
Michal
next prev parent reply other threads:[~2014-10-01 13:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 13:36 [PATCH 2/3] limit _shipped to c,h and S files Nicholas Mc Guire
2014-10-01 13:55 ` Michal Marek [this message]
2014-10-02 18:55 ` Nicholas Mc Guire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542C07BF.6030703@suse.cz \
--to=mmarek@suse.cz \
--cc=der.herr@hofr.at \
--cc=hch@infradead.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.