From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4] package/nginx: new package
Date: Wed, 01 Oct 2014 11:13:23 -0300 [thread overview]
Message-ID: <542C0C03.1040204@zacarias.com.ar> (raw)
In-Reply-To: <1412027000-15481-1-git-send-email-s.martin49@gmail.com>
On 09/29/2014 06:43 PM, Samuel Martin wrote:
Hi Samuel.
Nice job on keeping up with this one!
A couple of minor fixes:
> +config BR2_PACKAGE_NGINX_HTTP_SPDY_MODULE
> + bool "ngx_http_spdy_module"
> + help
> + Enable ngx_http_spdy_module
Needs a:
select BR2_PACKAGE_NGINX_HTTP_GZIP_MODULE
I guess we'll be seeing others like this as well, just tested a couple
obvious ones.
It's very likely as well that this option is useless without SSL support
since SPDY is like a souped-up TLS (even though it builds).
Also you're directing logfiles to /var/log/nginx but the directory is
never created by the systemd unit/initscript file. This leads to a
non-working default configuration.
Other than that it looks pretty good.
Regards.
prev parent reply other threads:[~2014-10-01 14:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-29 21:43 [Buildroot] [PATCH v4] package/nginx: new package Samuel Martin
2014-09-29 21:43 ` [Buildroot] [PATCH v8] package/canfestival: " Samuel Martin
2014-10-06 16:23 ` Thomas Petazzoni
2014-10-01 14:13 ` Gustavo Zacarias [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542C0C03.1040204@zacarias.com.ar \
--to=gustavo@zacarias.com.ar \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.