From: Alexander Graf <agraf@suse.de>
To: Bharata B Rao <bharata@linux.vnet.ibm.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH v0 0/2] target-ppc: Fix an invalid free
Date: Wed, 01 Oct 2014 17:04:27 +0200 [thread overview]
Message-ID: <542C17FB.9070603@suse.de> (raw)
In-Reply-To: <1411722458-21569-1-git-send-email-bharata@linux.vnet.ibm.com>
On 26.09.14 11:07, Bharata B Rao wrote:
> g_free() in target-ppc/translate_init.c:ppc_cpu_unrealizefn() can fail
> due to invalid pointer being passed to it. Fix this along with a cleanup.
>
> I have never seen ppc_cpu_unrealizefn() getting called for sPAPR guests,
> but I ran into this issue when I was adding unrealize call from the CPU
> hot removal path while working on CPU [un]hotplug support for sPAPR guests.
This opcode table handling code really is pretty ugly code :).
Thanks, applied both to ppc-next.
Alex
prev parent reply other threads:[~2014-10-01 15:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-26 9:07 [Qemu-devel] [RFC PATCH v0 0/2] target-ppc: Fix an invalid free Bharata B Rao
2014-09-26 9:07 ` [Qemu-devel] [RFC PATCH v0 1/2] target-ppc: Use macros in opcodes table handling code Bharata B Rao
2014-09-26 9:07 ` [Qemu-devel] [RFC PATCH v0 2/2] target-ppc: Fix an invalid free in opcode " Bharata B Rao
2014-10-01 15:04 ` Alexander Graf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542C17FB.9070603@suse.de \
--to=agraf@suse.de \
--cc=bharata@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.