From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48955)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XZMMA-0006oE-2J
	for qemu-devel@nongnu.org; Wed, 01 Oct 2014 12:02:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XZMLz-0005Lm-19
	for qemu-devel@nongnu.org; Wed, 01 Oct 2014 12:02:22 -0400
Received: from mail-pa0-x231.google.com ([2607:f8b0:400e:c03::231]:34333)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XZMLy-0005L8-Qw
	for qemu-devel@nongnu.org; Wed, 01 Oct 2014 12:02:10 -0400
Received: by mail-pa0-f49.google.com with SMTP id hz1so517985pad.36
	for <qemu-devel@nongnu.org>; Wed, 01 Oct 2014 09:02:09 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <542C257E.80309@twiddle.net>
Date: Wed, 01 Oct 2014 09:02:06 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1412156136-28899-1-git-send-email-kbastian@mail.uni-paderborn.de>
	<1412156136-28899-6-git-send-email-kbastian@mail.uni-paderborn.de>
In-Reply-To: <1412156136-28899-6-git-send-email-kbastian@mail.uni-paderborn.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 5/5] target-tricore: Add instructions of
 BO opcode format
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org

On 10/01/2014 02:35 AM, Bastian Koppelmann wrote:
> +    case OPC2_32_BO_ST_A_PREINC:
> +        tcg_gen_addi_tl(cpu_gpr_a[r2], cpu_gpr_a[r2], off10);
> +        tcg_gen_qemu_st_tl(cpu_gpr_a[r1], cpu_gpr_a[r2], ctx->mem_idx,
> +                           MO_LESL);
> +        break;

The writeback to A[r2] should not happen until after the memory operation, so
that if a memory exception occurs, A[r2] is not adjusted.


r~