From: Rick Jones <rick.jones2@hp.com>
To: eric.dumazet@gmail.com, netdev@vger.kernel.org
Cc: davem@davemloft.net
Subject: Re: [PATCH net-next] udp: increment UDP_NO_PORTS when dropping unmatched multicasts
Date: Wed, 01 Oct 2014 10:51:24 -0700 [thread overview]
Message-ID: <542C3F1C.2080108@hp.com> (raw)
In-Reply-To: <542C3D28.6050705@oracle.com>
On 10/01/2014 10:43 AM, David L Stevens wrote:
>
>
> On 10/01/2014 01:32 PM, Rick Jones wrote:
>
>> It would be an added statistic for "ignored" UDP multicast datagrams, incremented instead of UDP_MIB_NOPORTS. "UDP_MIB_IGNOREDMULTI" if you will.
>>
>> Similar in concept to what HP-UX NIC drivers would increment when they received a frame for which there was no bound protocol - "inbound unknown protocols" but not a drop
>> http://ptgmedia.pearsoncmg.com/images/chap1_0130428167/elementLinks/01fig16.gif
>
> I guess I'm ok with that.
>
> Ideally, it wouldn't be affected by running a sniffer, so I think best would be to increment
> NOPORTS when someone has joined the group on the interface and IGNOREDMULTI when nobody has,
> but I'm not sure it's worth the trouble to check. So I'm good with that, or IGNOREDMULTI all
> the time.
Eric -
What is your feeling? I have a UDP_MIB_NOPORTS v2 with UDP lite, fixed
inner_flushed and IPv6 I can post now, or I can tweak it to add an
IGNOREDMULTI stat and use that instead of NOPORTS. If taking the
IGNOREDMULTI path, I'd be inclined to go with consume_skb()
unconditionally since the philosophy would be that it is an ignored
packet rather than a drop (similar to the recent change in ARP).
rick
next prev parent reply other threads:[~2014-10-01 17:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 15:19 [PATCH net-next] udp: increment UDP_NO_PORTS when dropping unmatched multicasts Rick Jones
2014-10-01 15:41 ` Eric Dumazet
2014-10-01 15:54 ` David L Stevens
2014-10-01 16:32 ` Rick Jones
2014-10-01 16:59 ` David L Stevens
2014-10-01 17:32 ` Rick Jones
2014-10-01 17:43 ` David L Stevens
2014-10-01 17:51 ` Rick Jones [this message]
2014-10-01 17:14 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542C3F1C.2080108@hp.com \
--to=rick.jones2@hp.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.