All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Rae <srae@broadcom.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] usb: gadget: fastboot: explicitly set radix of maximum download size
Date: Wed, 1 Oct 2014 13:39:43 -0700	[thread overview]
Message-ID: <542C668F.1070204@broadcom.com> (raw)
In-Reply-To: <1412103942-28331-3-git-send-email-eric.nelson@boundarydevices.com>



On 14-09-30 12:05 PM, Eric Nelson wrote:
> The processing of the max-download-size variable requires a
> radix specifier, or the fastboot host tool will interpret
> it as an octal number.
>
> See function get_target_sparse_limit() in file fastboot/fastboot.c
> in the AOSP:
>          https://android.googlesource.com/platform/system/core/+/master
>
> Signed-off-by: Eric Nelson <eric.nelson@boundarydevices.com>
> ---
>   drivers/usb/gadget/f_fastboot.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/gadget/f_fastboot.c b/drivers/usb/gadget/f_fastboot.c
> index f970f89..86700f5 100644
> --- a/drivers/usb/gadget/f_fastboot.c
> +++ b/drivers/usb/gadget/f_fastboot.c
> @@ -355,7 +355,7 @@ static void cb_getvar(struct usb_ep *ep, struct usb_request *req)
>   		!strcmp_l1("max-download-size", cmd)) {
>   		char str_num[12];
>
> -		sprintf(str_num, "%08x", CONFIG_USB_FASTBOOT_BUF_SIZE);
> +		sprintf(str_num, "0x%08x", CONFIG_USB_FASTBOOT_BUF_SIZE);
>   		strncat(response, str_num, chars_left);
>   	} else if (!strcmp_l1("serialno", cmd)) {
>   		s = getenv("serial#");
>
(the host version of fastboot that I'm using requires this change!)
Tested-by: Steve Rae <srae@broadcom.com>

  reply	other threads:[~2014-10-01 20:39 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-30 19:05 [U-Boot] [PATCH 0/3] usb: gadget: fastboot miscellaneous patches Eric Nelson
2014-09-30 19:05 ` [U-Boot] [PATCH 1/3] usb: gadget: fastboot: add max-download-size variable Eric Nelson
2014-10-01 20:38   ` Steve Rae
2014-10-02  2:37     ` Marek Vasut
2014-10-02 16:50       ` Steve Rae
2014-09-30 19:05 ` [U-Boot] [PATCH 2/3] usb: gadget: fastboot: explicitly set radix of maximum download size Eric Nelson
2014-10-01 20:39   ` Steve Rae [this message]
2014-09-30 19:05 ` [U-Boot] [PATCH 3/3] usb: gadget: fastboot: terminate commands with NULL Eric Nelson
2014-10-01 20:40   ` Steve Rae
2014-10-01 21:23     ` Eric Nelson
2014-10-01 21:30     ` [U-Boot] [PATCH V2 " Eric Nelson
2014-09-30 19:37 ` [U-Boot] [PATCH 0/3] usb: gadget: fastboot miscellaneous patches Marek Vasut
2014-09-30 19:47   ` Eric Nelson
2014-09-30 23:59     ` Marek Vasut
2014-10-01  2:03       ` Eric Nelson
2014-10-01 12:13         ` Marek Vasut
2014-10-01 20:44           ` Steve Rae
2014-10-03 20:16             ` Marek Vasut
2014-10-06  9:23               ` Lukasz Majewski
2014-10-06 12:50                 ` Marek Vasut
2014-10-06 15:49                   ` Eric Nelson
2014-10-06 19:07                     ` Marek Vasut
2014-10-06 20:01                       ` Eric Nelson
2014-10-06 21:44                         ` Marek Vasut
2014-10-06 17:00                   ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=542C668F.1070204@broadcom.com \
    --to=srae@broadcom.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.