From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tetsuya Mukawa Subject: Re: [PATCH] Fix linking errors when CONFIG_RTE_BUILD_SHARED_LIB is enabled Date: Thu, 02 Oct 2014 10:43:52 +0900 Message-ID: <542CADD8.9070402@igel.co.jp> References: <1412137623-18817-1-git-send-email-mukawa@igel.co.jp> <20141001105022.GB21151@hmsreliant.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: dev-VfR2kkLFssw@public.gmane.org To: Neil Horman Return-path: In-Reply-To: <20141001105022.GB21151-B26myB8xz7F8NnZeBjwnZQMhkBWG/bsMQH7oEaQurus@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" (2014/10/01 19:50), Neil Horman wrote: > I'm not sure why thats necesecary. We add a --start-group/--end-group = pair > halfway through this makefile. If we just encompassed the entire set o= f > libraries in that group, order would be irrelevant. I haven't known the options. Thanks. Anyway, I understand I shouldn't change link order, but should check why '--start-group/--end-group' doesn't work on my environment. I will describe more in the email for Thomas. Regards, Tetsuya > Neil > >> Signed-off-by: Tetsuya Mukawa >> --- >> mk/rte.app.mk | 16 ++++++++-------- >> 1 file changed, 8 insertions(+), 8 deletions(-) >> >> diff --git a/mk/rte.app.mk b/mk/rte.app.mk >> index 34dff2a..172ba4d 100644 >> --- a/mk/rte.app.mk >> +++ b/mk/rte.app.mk >> @@ -121,10 +121,6 @@ endif >> =20 >> LDLIBS +=3D --start-group >> =20 >> -ifeq ($(CONFIG_RTE_LIBRTE_KVARGS),y) >> -LDLIBS +=3D -lrte_kvargs >> -endif >> - >> ifeq ($(CONFIG_RTE_LIBRTE_MBUF),y) >> LDLIBS +=3D -lrte_mbuf >> endif >> @@ -137,6 +133,10 @@ ifeq ($(CONFIG_RTE_LIBRTE_ETHER),y) >> LDLIBS +=3D -lethdev >> endif >> =20 >> +ifeq ($(CONFIG_RTE_LIBRTE_EAL),y) >> +LDLIBS +=3D -lrte_eal >> +endif >> + >> ifeq ($(CONFIG_RTE_LIBRTE_MALLOC),y) >> LDLIBS +=3D -lrte_malloc >> endif >> @@ -158,10 +158,6 @@ ifeq ($(CONFIG_RTE_LIBGLOSS),y) >> LDLIBS +=3D -lgloss >> endif >> =20 >> -ifeq ($(CONFIG_RTE_LIBRTE_EAL),y) >> -LDLIBS +=3D -lrte_eal >> -endif >> - >> ifeq ($(CONFIG_RTE_LIBRTE_CMDLINE),y) >> LDLIBS +=3D -lrte_cmdline >> endif >> @@ -174,6 +170,10 @@ ifeq ($(CONFIG_RTE_LIBRTE_PMD_BOND),y) >> LDLIBS +=3D -lrte_pmd_bond >> endif >> =20 >> +ifeq ($(CONFIG_RTE_LIBRTE_KVARGS),y) >> +LDLIBS +=3D -lrte_kvargs >> +endif >> + >> ifeq ($(CONFIG_RTE_LIBRTE_PMD_XENVIRT),y) >> LDLIBS +=3D -lrte_pmd_xenvirt >> LDLIBS +=3D -lxenstore >> --=20 >> 1.9.1 >> >>