Re: [PATCH 2/2] uas: Make uas work with blk-mq

[Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

Hi,

On 10/02/2014 03:25 PM, James Bottomley wrote:
> On Thu, 2014-10-02 at 15:18 +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 10/02/2014 03:12 PM, Christoph Hellwig wrote:
>>> On Thu, Oct 02, 2014 at 03:08:40PM +0200, Hans de Goede wrote:
>>>> Yes, although that likely would need to go through stable, without
>>>> going into 3.18 .
>>>>
>>>> Greg, is this ok with you and how do I get a patch in stable which
>>>> is not in upstream (because upstream will get a better fix) ?
>>>
>>> This is a trivial one liner and 3.17 isn't released yet, so can you just
>>> send it to Linus now?
>>
>> I don't think it is that urgent, given that block-mq is disabled by default
>> in 3.17 AFAIK. But feel free to send such a patch directly to Linus with my:
>>
>> Acked-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>>
>> Added, if that gets in, I guess I then need to do a v2 of the patch
>> from $subject, reverting it.
> 
> OK, so 3.17 should be on sunday giving three days or so to sort this
> out.  If you're happy with blk-mq being disabled so the bug never
> triggers unless the user activates it, doing nothing is my preferred
> outcome ... but that also means no need to backport to stable.  
> 
> If you want a it fixed in 3.17, then we need a patch from you now.
> Ultimately you have to judge the necessity for us, since it's your
> driver.

Fair enough. Given that this only triggers if the user enables an experimental
option, and then mixes that with uas usage, my preferred way to deal with this
is also doing nothing.

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html