From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZiPs-0003Pf-9e for qemu-devel@nongnu.org; Thu, 02 Oct 2014 11:35:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XZiPm-0002ei-1Q for qemu-devel@nongnu.org; Thu, 02 Oct 2014 11:35:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20114) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XZiPl-0002eV-PD for qemu-devel@nongnu.org; Thu, 02 Oct 2014 11:35:33 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s92FZWCO011203 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 2 Oct 2014 11:35:33 -0400 Message-ID: <542D70C3.8080804@redhat.com> Date: Thu, 02 Oct 2014 09:35:31 -0600 From: Eric Blake MIME-Version: 1.0 References: <1412261496-24455-1-git-send-email-armbru@redhat.com> <1412261496-24455-6-git-send-email-armbru@redhat.com> In-Reply-To: <1412261496-24455-6-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xUvh8MeS3cFULMSWdoBv6WjAVsARaTHpj" Subject: Re: [Qemu-devel] [PATCH 5/6] blockdev-test: Factor out some common code into helpers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xUvh8MeS3cFULMSWdoBv6WjAVsARaTHpj Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/02/2014 08:51 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > tests/drive_del-test.c | 60 +++++++++++++++++++++++++-----------------= -------- > 1 file changed, 30 insertions(+), 30 deletions(-) >=20 > diff --git a/tests/drive_del-test.c b/tests/drive_del-test.c > index 2baf0b7..463479d 100644 > --- a/tests/drive_del-test.c > +++ b/tests/drive_del-test.c > @@ -14,32 +14,44 @@ > #include > #include "libqtest.h" > =20 > +static void drive_add(void) > +{ > + QDict *response; > + > + response =3D qmp("{'execute': 'human-monitor-command'," > + " 'arguments': {" > + " 'command-line': 'drive_add 0 if=3Dnone,id=3Ddri= ve0'" > + "}}"); I'm still not necessarily a fan of '' in QMP, but this follows existing practice. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --xUvh8MeS3cFULMSWdoBv6WjAVsARaTHpj Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJULXDDAAoJEKeha0olJ0NqzsQH/A8i6euSXqgDqVu8UnGAJIeg xwh0WRnrKab7/aBgg3hWABg4Sg5ujtbOMT/ZRG5E804QyNnRNrdyZFFwhSD0fu0X Giu087EHK8P5EGrhcEVDzgrSP8/CnlDRu9lvFxGfwuNVvN6klEEEnLPB6J8Wb6Xl 6Suu3ZscYb+NSpQ+gbcmm7AD03LufzmndewM9A87LIpJ0f9pWlgd6Rp44BkScW0z 6tfk5SHoG7DuUukcUzA4hnT+fF9i8E9Ag5mh/kQ06SfnQUe1QAKWfQ+QI8rfKXwF DXmO/Vd+XhOC436Q+ubpRVSi+WZWFAfMHoGJdnCv0VL13PLEesex93d3nBzotEo= =Yjac -----END PGP SIGNATURE----- --xUvh8MeS3cFULMSWdoBv6WjAVsARaTHpj--