From: David Vrabel <david.vrabel@citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>,
Wen Congyang <wency@cn.fujitsu.com>,
coverity@xenproject.org, Shriram Rajagopalan <rshriram@cs.ubc.ca>,
xen-devel@lists.xenproject.org,
Yang Hongyang <yanghy@cn.fujitsu.com>
Subject: Re: Coverity complaints about Remus in xen-unstable
Date: Thu, 2 Oct 2014 18:45:54 +0100 [thread overview]
Message-ID: <542D8F52.7000908@citrix.com> (raw)
In-Reply-To: <21549.7204.27881.660089@mariner.uk.xensource.com>
On 02/10/14 10:34, Ian Jackson wrote:
>
> Is there a way to fix this in Coverity's modelling or should we report
> it as a false positive ?
I don't think this is a false positive -- coverity has correctly
identified the variable as unused. Perhaps you should tag the issue as
"Intentional"?
Longer term, I think libxl should move away from its profusion of macros
that declare local variables -- I think you nicely demonstrated that
they are confusing and that it's easy to forgot what they actually do.
David
next prev parent reply other threads:[~2014-10-02 17:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <542bcdb5e7156_555012573206153a@scan.coverity.com.mail>
2014-10-01 15:32 ` Coverity complaints about Remus in xen-unstable Ian Jackson
2014-10-01 16:34 ` Andrew Cooper
2014-10-02 9:34 ` Ian Jackson
2014-10-02 17:45 ` David Vrabel [this message]
2014-10-02 20:13 ` Andrew Cooper
2014-10-03 11:01 ` Coverity complaints about Remus in xen-unstable [and 1 more messages] Ian Jackson
2014-10-20 12:08 ` Coverity complaints about Remus in xen-unstable Hongyang Yang
2014-10-20 12:09 ` Hongyang Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542D8F52.7000908@citrix.com \
--to=david.vrabel@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=coverity@xenproject.org \
--cc=laijs@cn.fujitsu.com \
--cc=rshriram@cs.ubc.ca \
--cc=wency@cn.fujitsu.com \
--cc=xen-devel@lists.xenproject.org \
--cc=yanghy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.