Re: [PATCH 1/2] xen/arm: Initial support for PSCI-0.2

[Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com>]

On 10/02/2014 09:21 AM, Ian Campbell wrote:
> On Wed, 2014-10-01 at 15:02 -0500, suravee.suthikulpanit@amd.com wrote:
>> -int __init psci_init(void)
>> +void call_psci_system_off(void)
>> +{
>> +    if ( psci_ver > 2 )
>
> Doesn't this need to be >= to do anything on a 0.2 system? (Likewise in
> the fn below)

Ah yes. Thanks.
>
>> +        __invoke_psci_fn_smc(PSCI_0_2_FN_SYSTEM_OFF, 0, 0, 0);
>
> Should we print a message in the case that we aren't able to call the
> 0.2 handler? (again, likewise below)
>

I feel that this will be too verbose for the PSCI-0.1 case since this 
function always get called in the arch/arm/shutdown.c

Suravee