From: Michael Opdenacker <michael.opdenacker@free-electrons.com>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: vgupta@synopsys.com, richard@nod.at, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARC: [plat-arcfpga]: remove unused Kconfig params
Date: Thu, 02 Oct 2014 22:02:23 +0200 [thread overview]
Message-ID: <542DAF4F.1020701@free-electrons.com> (raw)
In-Reply-To: <1412158326.15281.2.camel@x220>
Hi Paul,
Thank you for reviewing my patch!
On 10/01/2014 12:12 PM, Paul Bolle wrote:
> On Wed, 2014-10-01 at 11:59 +0200, Michael Opdenacker wrote:
>> This removes the ARC_BOARD_ANGEL4 and ARC_BOARD_ML509
>> Kconfig parameters which are no longer used anywhere
>> in the source code and Makefiles.
>>
>> This also updates a comment refering to these parameters.
>>
>> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
>> ---
> See commit 774b689502d4 ("ARC: [arcfpga] Get rid of ARC_BOARD_ANGEL4 and
> ARC_BOARD_ML509") in linux-next since yesterday.
Great. Happy to drop my patch then!
>
>> arch/arc/plat-arcfpga/Kconfig | 13 -------------
>> 1 file changed, 13 deletions(-)
>>
>> diff --git a/arch/arc/plat-arcfpga/Kconfig b/arch/arc/plat-arcfpga/Kconfig
>> index b9f34cf55acf..3f6814aa97ac 100644
>> --- a/arch/arc/plat-arcfpga/Kconfig
>> +++ b/arch/arc/plat-arcfpga/Kconfig
>> @@ -12,23 +12,10 @@ menuconfig ARC_PLAT_FPGA_LEGACY
>> help
>> Support for ARC development boards, provided by Synopsys.
>> These are based on FPGA or ISS. e.g.
>> - - ARCAngel4
>> - - ML509
>> - MetaWare ISS
> It doesn't follow from the fact that these Kconfig symbols are unused
> that this help text is now incorrect. How did you establish that?
Oops, you're definitely right. Pfooh, starting to make the confusion
between data and metadata... scary.
Cheers,
Michael.
--
Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098
prev parent reply other threads:[~2014-10-02 20:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 9:59 [PATCH] ARC: [plat-arcfpga]: remove unused Kconfig params Michael Opdenacker
2014-10-01 10:12 ` Paul Bolle
2014-10-02 20:02 ` Michael Opdenacker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542DAF4F.1020701@free-electrons.com \
--to=michael.opdenacker@free-electrons.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=richard@nod.at \
--cc=vgupta@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.