From mboxrd@z Thu Jan 1 00:00:00 1970 From: Suravee Suthikulpanit Subject: Re: [V2 3/3] amd/seattle: Initial revision of AMD Seattle support Date: Thu, 2 Oct 2014 15:37:09 -0500 Message-ID: <542DB775.3030306@amd.com> References: <1412193085-30828-1-git-send-email-suravee.suthikulpanit@amd.com> <1412193085-30828-4-git-send-email-suravee.suthikulpanit@amd.com> <542D2BF2.2070205@linaro.org> <542DA1BE.3020301@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <542DA1BE.3020301@amd.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Julien Grall , stefano.stabellini@eu.citrix.com, ian.campbell@citrix.com Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 10/02/2014 02:04 PM, Suravee Suthikulpanit wrote: >>> +#include >>> + >>> +static const char * const seattle_dt_compat[] __initconst = >>> +{ >>> + "amd,seattle", >>> + NULL >>> +}; >>> + >>> +/* Seattle firmware only implements PSCI handler for >>> + * system off and system reset at this point. >>> + * This is temporary until full PSCI-0.2 is supported. >>> + * Then, these function will be removed. >>> + */ >>> +static noinline void seattle_smc_psci(register_t func_id) >>> +{ >>> + asm volatile( >>> + "smc #0" >>> + : "+r" (func_id) >>> + :); >>> +} >> >> We already have multiple implementation of smc in different place. Can >> we provide a common function rather than adding another one? > > The only place I found this is in the arch/arm/psci.c, which is used > mainly for the PSCI stuff. I can declare that one as non-static, and use > it here in the seattle.c. > > Suravee Julien, Actually, think about this again, I would rather keep this independent from the other PSCI patch series, which might not make it into 4.5. It is small enough and probably not too terrible to keep this. Thanks, Suravee