From: Igor Grinberg <grinberg@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] arm: mx6: cm_fx6: use gpio request
Date: Fri, 03 Oct 2014 09:45:15 +0300 [thread overview]
Message-ID: <542E45FB.1030001@compulab.co.il> (raw)
In-Reply-To: <1412259444-11959-3-git-send-email-nikita@compulab.co.il>
Hi Nikita,
On 10/02/14 17:17, Nikita Kiryanov wrote:
> Use gpio_request for all the gpios that are utilized by various
> subsystems in cm-fx6, and refactor the relevant init functions
> so that all gpios are requested during board_init(), not during
> subsystem init, thus avoiding the need to manage gpio ownership
> each time a subsystem is initialized.
>
> The new division of labor is:
> During board_init() muxes are setup and gpios are requested.
> During subsystem init gpios are toggled.
>
> Cc: Igor Grinberg <grinberg@compulab.co.il>
> Cc: Simon Glass <sjg@chromium.org>
> Signed-off-by: Nikita Kiryanov <nikita@compulab.co.il>
This looks much better.
I really don't like sticking the "has_been_inited" style of plugs,
while the same can be done by design and w/o such plugs.
Thanks Nikita.
Acked-by Igor Grinberg <grinberg@compulab.co.il>
--
Regards,
Igor.
next prev parent reply other threads:[~2014-10-03 6:45 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 1:57 [U-Boot] [PATCH v4 0/9] dm: imx: Add driver model support for GPIO and serial on cm_fx6 Simon Glass
2014-10-02 1:57 ` [U-Boot] [PATCH v4 1/9] dm: linker_lists: Add a way to declare multiple objects Simon Glass
2014-10-23 3:05 ` Simon Glass
2014-10-02 1:57 ` [U-Boot] [PATCH v4 2/9] dm: core: Allow a list of devices to be declared in one step Simon Glass
2014-10-23 3:05 ` Simon Glass
2014-10-02 1:57 ` [U-Boot] [PATCH v4 3/9] initcall: Display error number when an error occurs Simon Glass
2014-10-23 3:05 ` Simon Glass
2014-10-02 1:57 ` [U-Boot] [PATCH v4 4/9] dm: serial: Put common code into separate functions Simon Glass
2014-10-23 3:05 ` Simon Glass
2014-10-02 1:57 ` [U-Boot] [PATCH v4 5/9] imx: Add error checking to setup_i2c() Simon Glass
2014-10-23 3:06 ` Simon Glass
2014-10-02 1:57 ` [U-Boot] [PATCH v4 6/9] dm: imx: Use gpio_request() to request GPIOs Simon Glass
2014-10-02 14:17 ` [U-Boot] [PATCH 0/2] Split "dm: imx: Use gpio_request() to request GPIOs" Nikita Kiryanov
2014-10-02 14:17 ` [U-Boot] [PATCH 1/2] dm: imx: i2c: Use gpio_request() to request GPIOs Nikita Kiryanov
2014-10-03 6:39 ` Igor Grinberg
2014-10-14 7:25 ` Simon Glass
2014-10-21 9:51 ` Igor Grinberg
2014-10-23 3:06 ` Simon Glass
2014-10-02 14:17 ` [U-Boot] [PATCH 2/2] arm: mx6: cm_fx6: use gpio request Nikita Kiryanov
2014-10-02 19:22 ` Simon Glass
2014-10-03 7:41 ` Igor Grinberg
2014-10-03 14:04 ` Simon Glass
2014-10-05 10:52 ` Igor Grinberg
2014-10-05 18:32 ` Simon Glass
2014-10-06 5:47 ` Igor Grinberg
2014-10-03 6:45 ` Igor Grinberg [this message]
2014-10-23 3:06 ` Simon Glass
2014-10-02 14:18 ` [U-Boot] [PATCH v4 6/9] dm: imx: Use gpio_request() to request GPIOs Nikita Kiryanov
2014-10-02 16:06 ` Simon Glass
2014-10-02 1:57 ` [U-Boot] [PATCH v4 7/9] dm: imx: gpio: Support driver model in MXC gpio driver Simon Glass
2014-10-23 3:06 ` Simon Glass
2014-10-02 1:57 ` [U-Boot] [PATCH v4 8/9] dm: imx: serial: Support driver model in the MXC serial driver Simon Glass
2014-10-23 3:06 ` Simon Glass
2014-10-02 1:57 ` [U-Boot] [PATCH v4 9/9] dm: imx: Move cm_fx6 to use driver model for serial and GPIO Simon Glass
2014-10-02 14:16 ` Nikita Kiryanov
2014-10-23 3:06 ` Simon Glass
2014-10-02 1:59 ` [U-Boot] [PATCH v4 0/9] dm: imx: Add driver model support for GPIO and serial on cm_fx6 Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542E45FB.1030001@compulab.co.il \
--to=grinberg@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.