All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Baron <jbaron@akamai.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"kaber@trash.net" <kaber@trash.net>
Subject: Re: macvlan: optimizing the receive path?
Date: Fri, 03 Oct 2014 11:08:10 -0400	[thread overview]
Message-ID: <542EBBDA.8070209@akamai.com> (raw)
In-Reply-To: <20141002143136.2234c9e6@urahara>

On 10/02/2014 05:31 PM, Stephen Hemminger wrote:
> On Thu, 02 Oct 2014 16:28:13 -0400
> Jason Baron <jbaron@akamai.com> wrote:
> 
>> Hi,
>>
>> I was just wondering why the netif_rx(skb) call in macvlan_handle_frame()
>> was necessary? IE:
> 
> 
> It is to prevent too deep a call stack of
>   netif_receive_skb
>      macvlan_receive
>         netif_receive_skb ...
> 

So the concern is a stack overflow? The above nesting would really look like:

netif_receive_skb
        macvlan_receive
netif_receive_skb

b/c the macvlan_receive call would return. So its not clear to me that the
macvlan code would be adding to the stack depth here.

Thanks,

-Jason

  reply	other threads:[~2014-10-03 15:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-02 20:28 macvlan: optimizing the receive path? Jason Baron
2014-10-02 21:31 ` Stephen Hemminger
2014-10-03 15:08   ` Jason Baron [this message]
2014-10-03 16:16 ` Vlad Yasevich
2014-10-05  0:42 ` David Miller
2014-10-06 13:04   ` Vlad Yasevich
2014-10-07 17:35     ` Jason Baron
2014-10-07 18:00       ` Eric Dumazet
2014-10-07 18:49       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=542EBBDA.8070209@akamai.com \
    --to=jbaron@akamai.com \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.