From: Paolo Bonzini <pbonzini@redhat.com>
To: minyard@acm.org, qemu-devel@nongnu.org
Cc: mjg59@srcf.ucam.org, mst@redhat.com, hwd@huawei.com,
bcketchum@gmail.com, Corey Minyard <cminyard@mvista.com>,
afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets
Date: Sat, 04 Oct 2014 00:22:33 +0200 [thread overview]
Message-ID: <542F21A9.2050001@redhat.com> (raw)
In-Reply-To: <1412266658-25643-6-git-send-email-minyard@acm.org>
Il 02/10/2014 18:17, minyard@acm.org ha scritto:
> + if (!qemu_chr_open_socket_fd(chr, &err)) {
> + error_report("Unable to connect to char device %s\n", chr->label);
> + qemu_chr_socket_restart_timer(chr);
> + }
Can you please add a follow-up patch that only prints this message once
per reconnect? Otherwise a server that shuts down can spam logs forever.
I'll nevertheless queue the patches for 2.2 next week.
Thanks,
Paolo
next prev parent reply other threads:[~2014-10-03 22:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-02 16:17 [Qemu-devel] [PATCH v5 0/6] Add reconnecting to client sockets minyard
2014-10-02 16:17 ` [Qemu-devel] [PATCH 1/6] qemu-char: Make the filename size for a chardev a #define minyard
2014-10-02 16:17 ` [Qemu-devel] [PATCH 2/6] qemu-char: Rework qemu_chr_open_socket() for reconnect minyard
2014-10-02 16:17 ` [Qemu-devel] [PATCH 3/6] qemu-char: Move some items into TCPCharDriver minyard
2014-10-02 16:17 ` [Qemu-devel] [PATCH 4/6] qemu-char: set socket filename to disconnected when not connected minyard
2014-10-02 16:17 ` [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets minyard
2014-10-03 22:22 ` Paolo Bonzini [this message]
2014-10-04 3:24 ` Corey Minyard
2014-10-04 15:54 ` Paolo Bonzini
2014-10-02 16:17 ` [Qemu-devel] [PATCH 6/6] qemu-char: Print the remote and local addresses for a socket minyard
-- strict thread matches above, loose matches on Subject: below --
2014-10-01 21:09 [Qemu-devel] [PATCH v4 0/6] Add reconnect capability to sockets minyard
2014-10-01 21:09 ` [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets minyard
2014-10-02 12:25 ` Paolo Bonzini
2014-09-25 20:07 [Qemu-devel] [PATCH v3 0/6] chardev: " minyard
2014-09-25 20:07 ` [Qemu-devel] [PATCH 5/6] qemu-char: " minyard
2014-10-01 12:38 ` Corey Minyard
2014-10-01 18:15 ` Paolo Bonzini
2014-10-01 19:10 ` Eric Blake
2014-10-01 21:03 ` Corey Minyard
2014-09-22 16:59 [Qemu-devel] [PATCH v2 0/6] chardev: " minyard
2014-09-22 16:59 ` [Qemu-devel] [PATCH 5/6] qemu-char: " minyard
2014-09-22 20:26 ` Eric Blake
2014-09-21 23:04 [Qemu-devel] [PATCH 0/6] Add reconnect capability for " minyard
2014-09-21 23:04 ` [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to " minyard
2014-09-22 8:02 ` Paolo Bonzini
2014-09-22 20:24 ` Eric Blake
2014-09-22 20:36 ` Corey Minyard
2014-09-22 20:53 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542F21A9.2050001@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=bcketchum@gmail.com \
--cc=cminyard@mvista.com \
--cc=hwd@huawei.com \
--cc=minyard@acm.org \
--cc=mjg59@srcf.ucam.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.