Re: [PATCH 1/5] iio: adc: vf610: Propagate the real error when platform_get_irq() fails

[Jonathan Cameron <jic23@kernel.org>]

On 03/10/14 02:25, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> There is no need to pass a 'fake' return value when platform_get_irq() fails.
> 
> Propagate the real error instead. 
> 
> While at it, only consider negative numbers returned by platform_get_irq()
> as error.
Returning an irq of 0 is still invalid isn't it?
(there was a lot of 'fun' making this true for Arm a few years back).
Doesn't it effectively mean no irq is present?

Naturally I may have missed a change where it is allowed again!
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  drivers/iio/adc/vf610_adc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c
> index 4a10ae9..c259901 100644
> --- a/drivers/iio/adc/vf610_adc.c
> +++ b/drivers/iio/adc/vf610_adc.c
> @@ -569,9 +569,9 @@ static int vf610_adc_probe(struct platform_device *pdev)
>  		return PTR_ERR(info->regs);
>  
>  	irq = platform_get_irq(pdev, 0);
> -	if (irq <= 0) {
> +	if (irq < 0) {
>  		dev_err(&pdev->dev, "no irq resource?\n");
> -		return -EINVAL;
> +		return irq;
>  	}
>  
>  	ret = devm_request_irq(info->dev, irq,
>