All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
To: Kees Cook <keescook@chromium.org>, linux-hardening@vger.kernel.org
Cc: Anton Vorontsov <anton@enomsg.org>,
	Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
	Paramjit Oberoi <pso@chromium.org>,
	Ard Biesheuvel <ardb@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] MAINTAINERS: Update pstore maintainers
Date: Wed, 16 Nov 2022 12:42:53 -0300	[thread overview]
Message-ID: <542aa83d-6227-ea7d-2150-a74293cbf59a@igalia.com> (raw)
In-Reply-To: <20221011200112.731334-6-keescook@chromium.org>

On 11/10/2022 17:01, Kees Cook wrote:
> Update pstore to better reflect reality of active contributors:
> 
> - Remove Anton and Colin (thank you for your help through the years!)
> - Move Tony to Reviewer
> - Add Guilherme as Reviewer
> - Add mailing list
> - Upgrade to Supported
> 
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
>  MAINTAINERS | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Hi Kees, sorry to revamp this thread for a "tangential" topic, but it
feels a "kinda" proper thread.

Since I was added as a reviewer on pstore (in linux-next so far), I
started to receive a bunch of emails from ARM device-tree folks; they're
adding ramoops entries to their DTs and looping pstore folks.

Examples:

https://lore.kernel.org/linux-hardening/20221111120156.48040-1-angelogioacchino.delregno@collabora.com/

https://lore.kernel.org/linux-hardening/20221116145616.17884-1-luca@z3ntu.xyz/


Personally, I have no knowledge of these HW to evaluate if the ramoops
setting is appropriate, so they're nop from my side, I just delete them.
But that raises the question - are you/Tony reviewing this kind of
change? It's not related to pstore/ramoops code, it's just users setting
ramoops in their DTs, so seems to me a bit far from the purpose of the
pstore entry.

What do you/Tony think about that? Likely the DT folks are following
this entry in the MAINTAINERS to send these emails:

PSTORE FILESYSTEM
M:      Kees Cook <keescook@chromium.org>
[...]
F:      include/linux/pstore*
K:      \b(pstore|ramoops) <------

Should this be kept? Maybe only the ramoops entry could be removed?

Again, totally fine be me to keep'em, it's just that I'm receiving and
ignoring the emails, so if everybody else is doing the same, better to
just remove this entry from MAINTAINERS.

Thanks,


Guilherme

  parent reply	other threads:[~2022-11-16 16:00 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-11 20:01 [PATCH 0/5] Move internal definitions out of kernel-wide include Kees Cook
2022-10-11 20:01 ` [PATCH 1/5] pstore/ram: Consolidate kfree() paths Kees Cook
2022-10-12 19:43   ` Guilherme G. Piccoli
2022-10-11 20:01 ` [PATCH 2/5] pstore/ram: Move pmsg init earlier Kees Cook
2022-10-12 19:45   ` Guilherme G. Piccoli
2022-10-11 20:01 ` [PATCH 3/5] pstore/ram: Move internal definitions out of kernel-wide include Kees Cook
2022-10-12 19:46   ` Guilherme G. Piccoli
2022-10-12 21:51     ` Kees Cook
2022-10-11 20:01 ` [PATCH 4/5] pstore/ram: Set freed addresses to NULL Kees Cook
2022-10-12 19:44   ` Guilherme G. Piccoli
2022-10-11 20:01 ` [PATCH 5/5] MAINTAINERS: Update pstore maintainers Kees Cook
2022-10-11 20:26   ` Colin Cross
2022-10-11 20:35   ` Guilherme G. Piccoli
2022-10-11 22:20     ` Kees Cook
2022-10-12 15:15       ` Guilherme G. Piccoli
2022-11-16 15:42   ` Guilherme G. Piccoli [this message]
2022-11-17 22:01     ` Kees Cook
2022-11-17 22:05       ` Guilherme G. Piccoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=542aa83d-6227-ea7d-2150-a74293cbf59a@igalia.com \
    --to=gpiccoli@igalia.com \
    --cc=anton@enomsg.org \
    --cc=ardb@kernel.org \
    --cc=ccross@android.com \
    --cc=keescook@chromium.org \
    --cc=linux-hardening@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pso@chromium.org \
    --cc=tony.luck@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.