From: Daniel Borkmann <dborkman@redhat.com>
To: Sandy Harris <sandyinchina@gmail.com>
Cc: linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au,
tytso@mit.edu, hannes@stressinduktion.org, gmazyland@gmail.com,
julia.lawall@lip6.fr
Subject: Re: memset() in crypto code?
Date: Sun, 05 Oct 2014 12:33:50 +0200 [thread overview]
Message-ID: <54311E8E.7000107@redhat.com> (raw)
In-Reply-To: <CACXcFmkQSZrQHqmcauAvpyexkjL5YpNKa-O0Or1VMuU4hawzkA@mail.gmail.com>
Hi Sandy,
On 10/05/2014 05:09 AM, Sandy Harris wrote:
> There was recently a patch to the random driver to replace memset()
> because, according to the submitter, gcc sometimes optimises memset()
> away which might leave data unnecessarily exposed. The solution
> suggested was a function called memzero_explicit(). There was a fair
> bit of discussion and the patch was accepted.
>
> In the crypto directory of the kernel source I have:
>
> $ grep memset *.c | wc -l
> 133
> $
>
> I strongly suspect some of these should be fixed.
I have submitted it here one month ago for crypto and it's still
awaiting to be applied:
http://www.spinics.net/lists/linux-crypto/msg11965.html
As the random driver patch has been applied to random -dev, it will be
available from 3.18 onwards, but the dependency for crypto is currently
there, that's why I asked Ted to take it through his tree; hopefully
this will happen soonish (but I haven't heard anything back ever since) ...
Thanks!
Daniel
next prev parent reply other threads:[~2014-10-05 10:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-05 3:09 memset() in crypto code? Sandy Harris
2014-10-05 10:33 ` Daniel Borkmann [this message]
2014-10-06 17:44 ` Jason Cooper
2014-10-06 17:59 ` Sandy Harris
2014-10-06 18:23 ` Jason Cooper
2014-10-06 18:52 ` Sandy Harris
2014-10-06 19:02 ` Daniel Borkmann
2014-10-08 2:30 ` Sandy Harris
2014-10-08 7:18 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54311E8E.7000107@redhat.com \
--to=dborkman@redhat.com \
--cc=gmazyland@gmail.com \
--cc=hannes@stressinduktion.org \
--cc=herbert@gondor.apana.org.au \
--cc=julia.lawall@lip6.fr \
--cc=linux-crypto@vger.kernel.org \
--cc=sandyinchina@gmail.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.