From: Alex Gartrell <agartrell@fb.com>
To: Julian Anastasov <ja@ssi.bg>, Dan Carpenter <dan.carpenter@oracle.com>
Cc: lvs-devel@vger.kernel.org
Subject: Re: ipvs: Pull out crosses_local_route_boundary logic
Date: Sun, 5 Oct 2014 16:47:02 -0700 [thread overview]
Message-ID: <5431D876.5020002@fb.com> (raw)
In-Reply-To: <alpine.LFD.2.11.1410012225530.3494@ja.home.ssi.bg>
Hey everyone,
On 10/1/14 12:37 PM, Julian Anastasov wrote:
>> 312 *ret_saddr = saddr;
>> 313 }
>> 314
>> 315 local = (rt->rt_flags & RTCF_LOCAL) ? 1 : 0;
>> 316 if (unlikely(crosses_local_route_boundary(skb_af, skb, rt_mode,
>> 317 local))) {
>> 318 IP_VS_DBG_RL("We are crossing local and non-local addresses"
>> 319 " daddr=%pI4\n", &dest->addr.ip);
>> ^^^^^^^^^^^^^
>
> Good catch. In fact, I requested Alex to print
> daddr in this case but then we both missed this dest here...
> Alex, both v4 (&daddr) and v6 (daddr) should be fixed.
It doesn't appear to me that there's been a patch for this yet. I'll
write one and send it out right away. Please LMK if there's anyone else
I should send it to.
Thanks,
--
Alex Gartrell <agartrell@fb.com>
next prev parent reply other threads:[~2014-10-05 23:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 17:45 ipvs: Pull out crosses_local_route_boundary logic Dan Carpenter
2014-10-01 19:37 ` Julian Anastasov
2014-10-05 23:47 ` Alex Gartrell [this message]
2014-10-06 7:32 ` Simon Horman
2014-10-06 15:45 ` Alex Gartrell
2014-10-06 15:46 ` [PATCH net-next] ipvs: Avoid null-pointer deref in debug code Alex Gartrell
2014-10-06 15:46 ` Alex Gartrell
2014-10-06 19:01 ` Julian Anastasov
2014-10-17 6:27 ` Simon Horman
2014-10-06 0:54 ` Alex Gartrell
2014-10-06 0:54 ` Alex Gartrell
2014-10-06 6:49 ` Julian Anastasov
2014-10-06 15:56 ` Alex Gartrell
2014-10-06 15:56 ` Alex Gartrell
2014-10-06 19:13 ` Julian Anastasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5431D876.5020002@fb.com \
--to=agartrell@fb.com \
--cc=dan.carpenter@oracle.com \
--cc=ja@ssi.bg \
--cc=lvs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.