From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3 1/3] eal: export keepalive state
	enumerations
Date: Wed, 15 Jun 2016 11:27:07 +0200
Message-ID: <54322711.BUndy8Ap0U@xps13>
References: <1465982245-1162-1-git-send-email-remy.horton@intel.com>
 <1465982245-1162-2-git-send-email-remy.horton@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Remy Horton <remy.horton@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45])
 by dpdk.org (Postfix) with ESMTP id CF9E3C44A
 for <dev@dpdk.org>; Wed, 15 Jun 2016 11:27:09 +0200 (CEST)
Received: by mail-wm0-f45.google.com with SMTP id a66so14983842wme.0
 for <dev@dpdk.org>; Wed, 15 Jun 2016 02:27:09 -0700 (PDT)
In-Reply-To: <1465982245-1162-2-git-send-email-remy.horton@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-06-15 10:17, Remy Horton:
> +enum rte_keepalive_state {
> +	RTE_UNUSED = 0,
> +	RTE_ALIVE = 1,
> +	RTE_MISSING = 4,
> +	RTE_DEAD = 2,
> +	RTE_GONE = 3,
> +	RTE_DOZING = 5,
> +	RTE_SLEEP = 6
> +};

I'm concerned about the namespace here.
RTE_UNUSED and others have a chance to not be unique enough.
Is it possible to have a longer prefix like RTE_KA_ or RTE_STATE_
or RTE_KA_STATE_?